All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Guo Tenglong <micronull@163.com>,
	Philipp Reisner <philipp.reisner@linbit.com>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>,
	Jens Axboe <axboe@kernel.dk>,
	drbd-dev@lists.linux.dev, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drbd: fix typo in comment
Date: Mon, 10 Aug 2026 13:11:40 +0200	[thread overview]
Message-ID: <a95689f2-4965-4387-a7d3-64dcd5594f26@linbit.com> (raw)
In-Reply-To: <20260728090507.16847-1-micronull@163.com>



Am 28.07.26 um 11:05 schrieb Guo Tenglong:
> Correct "seperate" to "separate" in a comment.
> 
> Signed-off-by: Guo Tenglong <micronull@163.com>
> ---
>  drivers/block/drbd/drbd_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/drbd/drbd_state.c b/drivers/block/drbd/drbd_state.c
> index adcba7f1d..98abd2351 100644
> --- a/drivers/block/drbd/drbd_state.c
> +++ b/drivers/block/drbd/drbd_state.c
> @@ -1339,7 +1339,7 @@ _drbd_set_state(struct drbd_device *device, union drbd_state ns,
>  
>  	remember_new_state(state_change);
>  
> -	/* put replicated vs not-replicated requests in seperate epochs */
> +	/* put replicated vs not-replicated requests in separate epochs */
>  	if (drbd_should_do_remote((union drbd_dev_state)os.i) !=
>  	    drbd_should_do_remote((union drbd_dev_state)ns.i))
>  		start_new_tl_epoch(connection);

Thanks for the patch.
Typo fixes like this are generally only worth it if they come with a
"real" fix in the same general reason. On their own, they just cause
more work for the maintainers involved with no real benefit --
especially in this case, where I initially struggled to even see the
difference.

NAK.

-- 
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage


  parent reply	other threads:[~2026-08-10 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28  9:05 [PATCH] drbd: fix typo in comment Guo Tenglong
2026-07-28  9:05 ` [PATCH] drm/radeon: fix typo in comments Guo Tenglong
2026-08-10 11:13   ` Christoph Böhmwalder
2026-08-10 11:11 ` Christoph Böhmwalder [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-06-16 14:32 [PATCH] drbd: Fix typo in comment Xiang wangx
2022-06-22 14:12 ` Christoph Böhmwalder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a95689f2-4965-4387-a7d3-64dcd5594f26@linbit.com \
    --to=christoph.boehmwalder@linbit.com \
    --cc=axboe@kernel.dk \
    --cc=drbd-dev@lists.linux.dev \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micronull@163.com \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.