Re: [PATCH] drm/amdgpu/soc15: skip reset on init

["Lin, Amber" <Amber.Lin-5C7GfCeVMHo@public.gmane.org>]

On 2019-05-17 10:26 a.m., Alex Deucher wrote:
> [CAUTION: External Email]
>
> Not necessary on soc15 and breaks driver reload on server cards.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> ---
>   drivers/gpu/drm/amd/amdgpu/soc15.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 32dc5a128249..78bd4fc07bab 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -761,6 +761,11 @@ static bool soc15_need_reset_on_init(struct amdgpu_device *adev)
>   {
>          u32 sol_reg;
>
> +       /* Just return false for soc15 GPUs.  Reset does not seem to
> +        * be necessary.
> +        */
> +       return false;
> +
>          if (adev->flags & AMD_IS_APU)
>                  return false;
Should remove the rest of code in this function and sol_reg as well? 
Simply return false?
>
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx