From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABD6C83F10 for ; Thu, 31 Aug 2023 06:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236420AbjHaGuC (ORCPT ); Thu, 31 Aug 2023 02:50:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233852AbjHaGuB (ORCPT ); Thu, 31 Aug 2023 02:50:01 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1694AB4 for ; Wed, 30 Aug 2023 23:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693464598; x=1725000598; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6kcZ8h9lTsHGVhE1c9EO1Ak6pqJpZkYxV0ZLtyVD+ho=; b=SDB+yG+paUD39CmNQeJCtAvWp1NnnIt1lNEv1Ssy3GVRTUSQxhKMB4+l pfEAN0DqifBdRfn2IFoxiI4papAO6p8uHWM3IYacTN61Hl/bWU865Afm5 ZbJ+9K//pnvz8p0uSbFpS4xeLN/lZiA565svByYsNCkpPVB6BoMDy6Zj5 Rt/NpKz1OPrwZT/dOjixa94qiF98TJgRV0cr3ixWAC4qaIGm+GCTacKa8 TMe6SbSV5WXe64oC07pMzo4SAi3kBeZfG8ZPtkaaXGF3757UXrJ6b1Tlc jE6aRv36qC7kFpLv1Lzyv5s8XZyFA8uGjFmoH4xQjZQKDKzycV/1aRTpt g==; X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="373235654" X-IronPort-AV: E=Sophos;i="6.02,216,1688454000"; d="scan'208";a="373235654" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 23:49:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="768678181" X-IronPort-AV: E=Sophos;i="6.02,216,1688454000"; d="scan'208";a="768678181" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.16.87]) ([10.93.16.87]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 23:49:51 -0700 Message-ID: Date: Thu, 31 Aug 2023 14:49:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.14.0 Subject: Re: [PATCH v2 41/58] i386/tdx: handle TDG.VP.VMCALL Content-Language: en-US To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: Chenyi Qiang , Markus Armbruster , Paolo Bonzini , Richard Henderson , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , Ani Sinha , Peter Xu , David Hildenbrand , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Cornelia Huck , Eric Blake , Marcelo Tosatti , Gerd Hoffmann , qemu-devel@nongnu.org, kvm@vger.kernel.org, Eduardo Habkost , Laszlo Ersek , Isaku Yamahata , erdemaktas@google.com References: <20230818095041.1973309-1-xiaoyao.li@intel.com> <20230818095041.1973309-42-xiaoyao.li@intel.com> <87wmxn6029.fsf@pond.sub.org> <11130e51-72fe-a07a-767b-f768611cf0d9@intel.com> From: Xiaoyao Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 8/30/2023 3:48 PM, Daniel P. Berrangé wrote: > On Wed, Aug 30, 2023 at 01:57:59PM +0800, Xiaoyao Li wrote: >> On 8/30/2023 1:18 PM, Chenyi Qiang wrote: >>> >>> >>> On 8/29/2023 6:25 PM, Daniel P. Berrangé wrote: >>>> On Tue, Aug 29, 2023 at 01:31:37PM +0800, Chenyi Qiang wrote: >>>>> >>>>> >>>>> On 8/22/2023 4:24 PM, Daniel P. Berrangé wrote: >>>>>> On Tue, Aug 22, 2023 at 08:52:30AM +0200, Markus Armbruster wrote: >>>>>>> Xiaoyao Li writes: >>>>>>> >>>>>>>> From: Isaku Yamahata >>>>>>>> >>>>>>>> For GetQuote, delegate a request to Quote Generation Service. Add property >>>>>>>> of address of quote generation server and On request, connect to the >>>>>>>> server, read request buffer from shared guest memory, send the request >>>>>>>> buffer to the server and store the response into shared guest memory and >>>>>>>> notify TD guest by interrupt. >>>>>>>> >>>>>>>> "quote-generation-service" is a property to specify Quote Generation >>>>>>>> Service(QGS) in qemu socket address format. The examples of the supported >>>>>>>> format are "vsock:2:1234", "unix:/run/qgs", "localhost:1234". >>>>>>>> >>>>>>>> command line example: >>>>>>>> qemu-system-x86_64 \ >>>>>>>> -object 'tdx-guest,id=tdx0,quote-generation-service=localhost:1234' \ >>>>>>>> -machine confidential-guest-support=tdx0 >>>>>>>> >>>>>>>> Signed-off-by: Isaku Yamahata >>>>>>>> Signed-off-by: Xiaoyao Li >>>>>>>> --- >>>>>>>> qapi/qom.json | 5 +- >>>>>>>> target/i386/kvm/tdx.c | 380 ++++++++++++++++++++++++++++++++++++++++++ >>>>>>>> target/i386/kvm/tdx.h | 7 + >>>>>>>> 3 files changed, 391 insertions(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/qapi/qom.json b/qapi/qom.json >>>>>>>> index 87c1d440f331..37139949d761 100644 >>>>>>>> --- a/qapi/qom.json >>>>>>>> +++ b/qapi/qom.json >>>>>>>> @@ -879,13 +879,16 @@ >>>>>>>> # >>>>>>>> # @mrownerconfig: MROWNERCONFIG SHA384 hex string of 48 * 2 length (default: 0) >>>>>>>> # >>>>>>>> +# @quote-generation-service: socket address for Quote Generation Service(QGS) >>>>>>>> +# >>>>>>>> # Since: 8.2 >>>>>>>> ## >>>>>>>> { 'struct': 'TdxGuestProperties', >>>>>>>> 'data': { '*sept-ve-disable': 'bool', >>>>>>>> '*mrconfigid': 'str', >>>>>>>> '*mrowner': 'str', >>>>>>>> - '*mrownerconfig': 'str' } } >>>>>>>> + '*mrownerconfig': 'str', >>>>>>>> + '*quote-generation-service': 'str' } } >>>>>>> >>>>>>> Why not type SocketAddress? >>>>>> >>>>>> Yes, the code uses SocketAddress internally when it eventually >>>>>> calls qio_channel_socket_connect_async(), so we should directly >>>>>> use SocketAddress in the QAPI from the start. >>>>> >>>>> Any benefit to directly use SocketAddress? >>>> >>>> We don't want whatever code consumes the configuration to >>>> do a second level of parsing to convert the 'str' value >>>> into the 'SocketAddress' object it actually needs. >>>> >>>> QEMU has a long history of having a second round of ad-hoc >>>> parsing of configuration and we've found it to be a serious >>>> maintenence burden. Thus we strive to have everything >>>> represented in QAPI using the desired final type, and avoid >>>> the second round of parsing. >>> >>> Thanks for your explanation. >>> >>>> >>>>> "quote-generation-service" here is optional, it seems not trivial to add >>>>> and parse the SocketAddress type in QEMU command. After I change 'str' >>>>> to 'SocketAddress' and specify the command like "-object >>>>> tdx-guest,type=vsock,cid=2,port=1234...", it will report "invalid >>>>> parameter cid". >>>> >>>> The -object parameter supports JSON syntax for this reason >>>> >>>> -object '{"qom-type":"tdx-guest","quote-generation-service":{"type": "vsock", "cid":"2","port":"1234"}}' >>>> >>>> libvirt will always use the JSON syntax for -object with a new enough >>>> QEMU. >>> >>> The JSON syntax works for me. Then, we need to add some doc about using >>> JSON syntax when quote-generation-service is required. >> >> This limitation doesn't look reasonable to me. >> >> @Daniel, >> >> Is it acceptable by QEMU community? > > This is the expected approach for object types which have non-scalar > properties. Learned it. thanks! > With regards, > Daniel