From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Alex Elder <elder@ieee.org>, Alex Elder <elder@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH net-next] net: ipa: Drop unused qmi_elem_info arrays
Date: Thu, 29 Oct 2026 20:17:33 +0100 [thread overview]
Message-ID: <a9910bba-5a4d-4eae-905f-4e576b03e112@oss.qualcomm.com> (raw)
In-Reply-To: <97e9474a-f491-4447-b128-e4a5687056ab@ieee.org>
On 29/10/2026 19:02, Alex Elder wrote:
> On 10/29/26 6:11 AM, Krzysztof Kozlowski wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Did you send this before? (Why the From:?)
Old commit I forgot to send at some point.
>
>> 'ipa_mem_array_ei' is not used anywhere, so can be dropped completely.
>> 'ipa_mem_bounds_ei' and 'ipa_mem_range_ei' are not used outside of their
>> units, so they can be narrowed to file-scope.
>
> I wonder why ipa_mem_array_ei was still defined. It must have
> been used at some point... Anyway, you're right, it's not
> used, so good riddance.
>
> Did you find these by inspection?
I was going once through all these QMI arrays through multiple drivers.
>
> Reviewed-by: Alex Elder <elder@riscstar.com>
>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-29 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 11:11 [PATCH net-next] net: ipa: Drop unused qmi_elem_info arrays Krzysztof Kozlowski
2026-10-29 18:02 ` Alex Elder
2026-10-29 19:17 ` Krzysztof Kozlowski [this message]
2026-10-29 21:05 ` Alex Elder
2026-10-30 22:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9910bba-5a4d-4eae-905f-4e576b03e112@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.