All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Marek Vasut <marex@denx.de>, linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam <festevam@denx.de>,
	NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mm: Model PMIC to SNVS RTC clock path on Data Modul i.MX8M Mini eDM SBC
Date: Mon, 26 Sep 2022 15:59:17 +0800	[thread overview]
Message-ID: <a9b31ad1-4b49-de38-e1fa-67e7e6345e88@oss.nxp.com> (raw)
In-Reply-To: <20220924174603.458956-1-marex@denx.de>



On 9/25/2022 1:46 AM, Marek Vasut wrote:
> The PMIC is the 32 kHz clock source for the RTC_XTALI input of the SoC
> on this system. The RTC_XTALI input is used to supply 32 kHz clock to
> the SVNS RTC per "i.MX 8M Mini Applications Processor Reference Manual,
> Rev. 3, 11/2020" page 759 "The 32KHz XTAL module uses a different IP and
> it is used as the clock source for the RTC, located in the SNVS." The
> PMIC has its own dedicated 32 kHz XTAL on input.
> 
> Model the connection in DT.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> To: linux-arm-kernel@lists.infradead.org
> ---
>   .../dts/freescale/imx8mm-data-modul-edm-sbc.dts     | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index 6ff30cbb32fb2..575d5632296c5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> @@ -53,6 +53,12 @@ clk_xtal25: clk-xtal25 {
>   		clock-frequency = <25000000>;
>   	};
>   
> +	clk_xtal32k: clk-xtal32k {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <32768>;
> +	};
> +
>   	panel: panel {
>   		backlight = <&backlight>;
>   		power-supply = <&reg_panel_vcc>;
> @@ -276,6 +282,9 @@ &i2c1 {
>   	pmic: pmic@4b {
>   		compatible = "rohm,bd71847";
>   		reg = <0x4b>;
> +		#clock-cells = <0>;
> +		clocks = <&clk_xtal32k 0>;
> +		clock-output-names = "clk-32k-out";
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&pinctrl_pmic>;
>   		interrupt-parent = <&gpio1>;
> @@ -942,6 +951,10 @@ &sai5 {
>   	status = "disabled";
>   };
>   
> +&snvs_rtc {
> +	clocks = <&pmic>;
> +};
> +
>   &uart1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&pinctrl_uart1>;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-26  8:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-24 17:46 [PATCH] arm64: dts: imx8mm: Model PMIC to SNVS RTC clock path on Data Modul i.MX8M Mini eDM SBC Marek Vasut
2022-09-26  7:59 ` Peng Fan [this message]
2022-09-27 19:43 ` Tim Harvey
2022-09-27 20:10   ` Marek Vasut
2022-09-27 20:23     ` Tim Harvey
2022-09-27 20:31       ` Marek Vasut
2022-09-27 20:43         ` Tim Harvey
2022-09-27 21:08           ` Marek Vasut
2022-10-24  1:23 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9b31ad1-4b49-de38-e1fa-67e7e6345e88@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=festevam@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.