From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
Sebastian Czapla <sebastianx.czapla@intel.com>,
<netdev@vger.kernel.org>,
Grzegorz Szczurek <grzegorzx.szczurek@intel.com>,
Marek Szlosek <marek.szlosek@intel.com>
Subject: Re: [PATCH net-next 1/6] i40e: Add flag for disabling VF source pruning
Date: Thu, 9 Feb 2023 09:19:45 -0800 [thread overview]
Message-ID: <a9be5ccc-d57d-8a87-41bb-5b0a44fa3924@intel.com> (raw)
In-Reply-To: <20230207215643.43f76bdd@kernel.org>
On 2/7/2023 9:56 PM, Jakub Kicinski wrote:
> On Mon, 6 Feb 2023 15:56:30 -0800 Tony Nguyen wrote:
>> Allow user to change source pruning for VF VSIs. This allows VFs to
>> receive packets with MAC_SRC and MAC_DST equal to VFs mac.
>>
>> Added priv flag vf-source-pruning to allow user to change
>> source pruning setting. Reset all VSIs to commit the setting.
>> If vf-source-pruning is off and VF is trusted on with spoofchk off
>> then disable source pruning on specific VF takes effect.
>>
>> Without this patch it is not possible to change source pruning
>> setting on VF VSIs.
>
> Intel keeps trickling in private flags to adjust the behavior of legacy
> SR-IOV NDOs. No documentation, no well understood semantics.
> This does not seem defensible upstream when we already started rejecting
> any use of legacy SR-IOV NDOs in new drivers.
Will drop this patch.
Thanks,
Tony
next prev parent reply other threads:[~2023-02-09 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 23:56 [PATCH net-next 0/6][pull request] Intel Wired LAN Driver Updates 2023-02-06 (i40e) Tony Nguyen
2023-02-06 23:56 ` [PATCH net-next 1/6] i40e: Add flag for disabling VF source pruning Tony Nguyen
2023-02-08 5:56 ` Jakub Kicinski
2023-02-09 17:19 ` Tony Nguyen [this message]
2023-02-06 23:56 ` [PATCH net-next 2/6] i40e: Remove unused i40e status codes Tony Nguyen
2023-02-06 23:56 ` [PATCH net-next 3/6] i40e: Remove string printing for i40e_status Tony Nguyen
2023-02-06 23:56 ` [PATCH net-next 4/6] i40e: use int " Tony Nguyen
2023-02-06 23:56 ` [PATCH net-next 5/6] i40e: use ERR_PTR error print in i40e messages Tony Nguyen
2023-02-06 23:56 ` [Intel-wired-lan] [PATCH net-next 6/6] net/i40e: Replace 0-length array with flexible array Tony Nguyen
2023-02-06 23:56 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9be5ccc-d57d-8a87-41bb-5b0a44fa3924@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grzegorzx.szczurek@intel.com \
--cc=kuba@kernel.org \
--cc=marek.szlosek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastianx.czapla@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.