All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
To: openbmc@lists.ozlabs.org
Cc: apparao.puli@linux.intel.com, richard.marian.thomaiyar@linux.intel.com
Subject: service-config-manager performance issue
Date: Mon, 21 Feb 2022 20:41:52 +0800	[thread overview]
Message-ID: <a9db0239-a53a-9a6f-e167-335dc8e56872@linux.intel.com> (raw)

Hi, all

When updating service status with service-config-manager, it always takes ~15s for the new status to be applied, which is much longer than it should be.

By inspecting the code, I found there is a 15s wait before updating service status in ServiceConfig::startServiceRestartTimer(). (https://github.com/openbmc/service-config-manager/blob/f2744893b77b9dd8903bb13113f4c3ef62c18f04/src/srvcfg_manager.cpp#L382)

The 15s-wait is added at first in commit 0084047 (https://github.com/openbmc/service-config-manager/commit/0084047d008fd0ac36f09a232f67ff2fc5314b53).

I've tested service-config-manager works as expected with the wait removed, and it only takes ~1s for the settings being applied, shall we remove it? And I'd like to ask what is the purpose of this wait to double confirm if removing it will bring any side effect.

Thanks,
Jiaqing

             reply	other threads:[~2022-02-21 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 12:41 Jiaqing Zhao [this message]
2022-02-21 20:00 ` service-config-manager performance issue Joseph Reynolds
2022-02-22  4:06   ` Jiaqing Zhao
2022-03-07  9:25   ` Jiaqing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9db0239-a53a-9a6f-e167-335dc8e56872@linux.intel.com \
    --to=jiaqing.zhao@linux.intel.com \
    --cc=apparao.puli@linux.intel.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=richard.marian.thomaiyar@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.