From: Thomas Huth <thuth@redhat.com>
To: Claudio Fontana <cfontana@suse.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: meson, NEED_CPU_H, CONFIG_TCG and tests/
Date: Fri, 19 Feb 2021 14:30:20 +0100 [thread overview]
Message-ID: <a9f6fbf7-fb29-eca6-44f0-91381e8b3084@redhat.com> (raw)
In-Reply-To: <eb7d8eca-13ef-07cf-41b4-d7276399fff1@suse.de>
On 19/02/2021 14.04, Claudio Fontana wrote:
> Hi Paolo,
>
> currently we have use of CONFIG_TCG in tests/,
>
> but is that variable available at all in there?
>
> I have to adapt some qemu/tests/qtest/* to work also without tcg for ARM,
>
> but I think I am not seeing CONFIG_TCG filtering through, and I wonder whether all the checks in there are actually "wrong".
>
> Looking at meson.build it would seem to me that only stuff in target/ would be able to see CONFIG_TCG,
> as a result of
>
> foreach target : target_dirs
> config_target = config_target_mak[target]
> target_name = config_target['TARGET_NAME']
> arch = config_target['TARGET_BASE_ARCH']
> arch_srcs = [config_target_h[target]]
> arch_deps = []
> c_args = ['-DNEED_CPU_H',
> '-DCONFIG_TARGET="@0@-config-target.h"'.format(target),
> '-DCONFIG_DEVICES="@0@-config-devices.h"'.format(target)]
>
> But how could tests see this?
The test are generic, not target-specific code, so they can not see things
like NEED_CPU_H, of course.
But CONFIG_TCG seems to be defined in config-host.h, so you should be able
to use that define, shouldn't you?
Thomas
next prev parent reply other threads:[~2021-02-19 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 13:04 meson, NEED_CPU_H, CONFIG_TCG and tests/ Claudio Fontana
2021-02-19 13:13 ` Claudio Fontana
2021-02-19 13:14 ` Philippe Mathieu-Daudé
2021-02-19 13:17 ` Claudio Fontana
2021-02-19 13:48 ` Philippe Mathieu-Daudé
2021-02-19 13:54 ` Claudio Fontana
2021-02-19 13:30 ` Thomas Huth [this message]
2021-02-19 16:04 ` Paolo Bonzini
2021-02-19 17:24 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f6fbf7-fb29-eca6-44f0-91381e8b3084@redhat.com \
--to=thuth@redhat.com \
--cc=cfontana@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.