From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net] net: phy: fix phy_init_hw fixup handling
Date: Sun, 23 Dec 2018 18:30:47 +0100
Message-ID: <a9fbe47e-60de-c9d4-604b-3ecfb74a8768@gmail.com>
References: <07a7d513-cf5c-99b5-c5ac-337bed2d00dd@gmail.com>
 <20181223170759.GC2791@lunn.ch>
 <22637042-a3c0-de58-10a6-cd86a0af976a@gmail.com>
 <20181223172858.GE2791@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f65.google.com ([209.85.221.65]:36025 "EHLO
        mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725308AbeLWRz3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 23 Dec 2018 12:55:29 -0500
Received: by mail-wr1-f65.google.com with SMTP id u4so9867319wrp.3
        for <netdev@vger.kernel.org>; Sun, 23 Dec 2018 09:55:28 -0800 (PST)
In-Reply-To: <20181223172858.GE2791@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 23.12.2018 18:28, Andrew Lunn wrote:
> On Sun, Dec 23, 2018 at 06:23:18PM +0100, Heiner Kallweit wrote:
>> On 23.12.2018 18:07, Andrew Lunn wrote:
>>> On Sun, Dec 23, 2018 at 03:00:26PM +0100, Heiner Kallweit wrote:
>>>> Currently we return immediately if callback config_init isn't defined.
>>>> This prevents the fixups from being executed. I see no dependency
>>>> between fixups and config_init, therefore change the function to
>>>> run the fixups also if config_init isn't defined.
>>>>
>>>> Fixes: 2f5cb43406d0 ("phylib: Properly reinitialize PHYs after hibernation")
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>
>>> Hi Heiner
>>>
>>> Is this a real fix? It seems like it has been like this forever. Do
>>> you know of a PHY which is actually broken?
>>>
>> Right, the current behavior has been there forever. I'm not aware of
>> any concrete case. I went for "net" because the current code could
>> break a device.
> 
> Hi Heiner
> 
> https://www.kernel.org/doc/html/v4.15/process/stable-kernel-rules.html
> 
> The 4th bullet point:
> 
> o It must fix a real bug that bothers people (not a, “This could be a
>   problem...” type thing).
> 
OK, this answers the question. Thanks.

>     Andrew
> 
Heiner