From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Check caller held wakerefs in assert_forcewakes_active Date: Thu, 4 Jul 2019 09:10:32 +0100 Message-ID: References: <20190703121204.30754-1-chris@chris-wilson.co.uk> <156215810772.20783.4447386209912059358@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 647EC6E2E3 for ; Thu, 4 Jul 2019 08:10:33 +0000 (UTC) In-Reply-To: <156215810772.20783.4447386209912059358@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAzLzA3LzIwMTkgMTM6NDgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA3LTAzIDEzOjQzOjM0KQo+Pgo+PiBPbiAwMy8wNy8yMDE5IDEzOjEy LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBUaGUgaW50ZW50IG9mIHRoZSBhc3NlcnQgaXMgdG8g ZG9jdW1lbnQgdGhhdCB0aGUgY2FsbGVyIHRvb2sgdGhlCj4+PiBhcHByb3ByaWF0ZSB3YWtlcmVm cyBmb3IgdGhlIGZ1bmN0aW9uLiBIb3dldmVyLCBhcyBUdnJ0a28gcG9pbnRlZCBvdXQsCj4+PiB3 ZSBzaW1wbHkgY2hlY2sgd2hldGhlciB0aGUgZndfZG9tYWlucyBhcmUgYWN0aXZlIGFuZCBtYXkg YmUgY29uZnVzZWQgYnkKPj4+IHRoZSBhdXRvIHdha2VyZWYgd2hpY2ggbWF5IGJlIGRyb3BwZWQg YmV0d2VlbiB0aGUgY2hlY2sgYW5kIHVzZS4gTGV0J3MKPj4+IGJlIG1vcmUgY2FyZWZ1bCBpbiB0 aGUgYXNzZXJ0IGFuZCBjaGVjayB0aGF0IGVhY2ggZndfZG9tYWluIGhhcyBhbgo+Pj4gZXhwbGlj aXQgY2FsbGVyIHdha2VyZWYgYWJvdmUgYW5kIGJleW9uZCB0aGUgYXV0b21hdGljIHdha2VyZWYu Cj4+Cj4+IEFsdGhvdWdoIHdlIHN0aWxsIGRvbid0IGtub3cgaWYgaXQgaXMgb3VyIGNhbGxlciB3 aG8gdG9vayB0aGUgZncgb3Igc29tZQo+PiB1bnJlbGF0ZWQgdGhyZWFkLiBTdGlsbCwgYSBtb3Jl IHRob3JvdWdoIGNoZWNrIGlzIGJldHRlciBldmVuIGlmIG5vdAo+PiBwZXJmZWN0Lgo+IAo+IFNp bmNlIGl0J3Mgbm90IGEgbXV0ZXgsIHdlIGNhbid0IHN0dWZmIGFuIG93bmVyIGZpZWxkIGluIGhl cmUsIHRoZSBvbmx5Cj4gd2F5IHRvIHByb3Blcmx5IHRyYWNrIGluIHRoYXQgY2FzZSB3b3VsZCBi ZSB0byByZXR1cm4gY29va2llcyBmcm9tCj4gZm9yY2V3YWtlX2dldCBhbmQgdmVyaWZ5IHRoZSBj b29raWVzIGFyZSBzdGlsbCBhY3RpdmUuCj4gCj4gTm90IGZlZWxpbmcgdGhlIGluY2xpbmF0aW9u IHRvIGRvIHRoYXQgeWV0LiBNYXliZSBpZiB3ZSBnZXQgYSBmZXcgZncKPiBsZWFrcy4KCkFncmVl ZCwgSSB3YXNuJ3QgdHJ5aW5nIHRvIHNheSB3ZSBoYXZlIHRvIGRvIGl0LgoKPiAKPj4+IFJlcG9y dGVkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pj4gU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBD YzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+IENjOiBNaWth IEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPj4+IC0tLQo+Pj4gICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgfCAyNCArKysrKysrKysrKysrKysr KysrKysrKysKPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspCj4+Pgo+Pj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPj4+IGluZGV4IDY4ZDU0ZTEyNmQ3OS4uYmMy NWE2ZTUxNDYzIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5j b3JlLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4+PiBA QCAtNzM4LDYgKzczOCwxMiBAQCB2b2lkIGFzc2VydF9mb3JjZXdha2VzX2luYWN0aXZlKHN0cnVj dCBpbnRlbF91bmNvcmUgKnVuY29yZSkKPj4+ICAgIHZvaWQgYXNzZXJ0X2ZvcmNld2FrZXNfYWN0 aXZlKHN0cnVjdCBpbnRlbF91bmNvcmUgKnVuY29yZSwKPj4+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZW51bSBmb3JjZXdha2VfZG9tYWlucyBmd19kb21haW5zKQo+Pj4gICAgewo+Pj4g KyAgICAgc3RydWN0IGludGVsX3VuY29yZV9mb3JjZXdha2VfZG9tYWluICpkb21haW47Cj4+PiAr ICAgICB1bnNpZ25lZCBpbnQgdG1wOwo+Pj4gKwo+Pj4gKyAgICAgaWYgKCFJU19FTkFCTEVEKENP TkZJR19EUk1faTkxNV9SVU5USU1FX1BNKSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuOwo+Pj4g Kwo+Pgo+PiBJZiB1bmNvcmUtPmZ1bmNzLmZvcmNlX3dha2VfZ2V0IGlzIHNldCB3aHkgd291bGRu J3Qgd2Ugc3RpbGwgd2FudCB0byBydW4KPj4gdGhlIGFzc2VydHM/Cj4gCj4gSSdtIGp1c3QgYmVp bmcgd29ycmllZCBieSBhZGRpbmcgYSBsb29wIHVuZGVyIGlycS1vZmYgYW5kIGRpZG4ndCB3YW50 IHRvCj4gYWRkIG1vcmUgdHJvdWJsZSB0byBub24tZGVidWcga2VybmVscy4gKENsb3NpbmcgdGhl IHN0YWJsZSBkb29yIG11Y2g/KQoKV2hhdCBpcyB0aGUgY29ubmVjdGlvbiBiZXR3ZWVuIGRlYnVn L25vbi1kZWJ1ZyBrZXJuZWxzIGFuZCAKQ09ORklHX0RSTV9pOTE1X1JVTlRJTUVfUE0/CgpSZWdh cmRzLAoKVHZydGtvCgo+Pgo+Pj4gICAgICAgIGlmICghdW5jb3JlLT5mdW5jcy5mb3JjZV93YWtl X2dldCkKPj4+ICAgICAgICAgICAgICAgIHJldHVybjsKPj4+ICAgIAo+Pj4gQEAgLTc0Nyw2ICs3 NTMsMjQgQEAgdm9pZCBhc3NlcnRfZm9yY2V3YWtlc19hY3RpdmUoc3RydWN0IGludGVsX3VuY29y ZSAqdW5jb3JlLAo+Pj4gICAgICAgIFdBUk4oZndfZG9tYWlucyAmIH51bmNvcmUtPmZ3X2RvbWFp bnNfYWN0aXZlLAo+Pj4gICAgICAgICAgICAgIkV4cGVjdGVkICUwOHggZndfZG9tYWlucyB0byBi ZSBhY3RpdmUsIGJ1dCAlMDh4IGFyZSBvZmZcbiIsCj4+PiAgICAgICAgICAgICBmd19kb21haW5z LCBmd19kb21haW5zICYgfnVuY29yZS0+ZndfZG9tYWluc19hY3RpdmUpOwo+Pj4gKwo+Pj4gKyAg ICAgLyoKPj4+ICsgICAgICAqIENoZWNrIHRoYXQgdGhlIGNhbGxlciBoYXMgYW4gZXhwbGljaXQg d2FrZXJlZiBhbmQgd2UgZG9uJ3QgbWlzdGFrZQo+Pj4gKyAgICAgICogaXQgZm9yIHRoZSBhdXRv IHdha2VyZWYuCj4+PiArICAgICAgKi8KPj4+ICsgICAgIGxvY2FsX2lycV9kaXNhYmxlKCk7Cj4+ PiArICAgICBmb3JfZWFjaF9md19kb21haW5fbWFza2VkKGRvbWFpbiwgZndfZG9tYWlucywgdW5j b3JlLCB0bXApIHsKPj4+ICsgICAgICAgICAgICAgdW5zaWduZWQgaW50IGV4cGVjdCA9IDE7Cj4+ PiArCj4+PiArICAgICAgICAgICAgIGlmIChocnRpbWVyX2FjdGl2ZSgmZG9tYWluLT50aW1lcikp Cj4+PiArICAgICAgICAgICAgICAgICAgICAgZXhwZWN0Kys7Cj4+PiArCj4+PiArICAgICAgICAg ICAgIGlmIChXQVJOKGRvbWFpbi0+d2FrZV9jb3VudCA8IGV4cGVjdCwKPj4+ICsgICAgICAgICAg ICAgICAgICAgICAgIkV4cGVjdGVkIGRvbWFpbiAlZCB0byBiZSBoZWxkIGF3YWtlIGJ5IGNhbGxl clxuIiwKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgZG9tYWluLT5pZCkpCj4+PiArICAgICAg ICAgICAgICAgICAgICAgYnJlYWs7Cj4+PiArICAgICB9Cj4+PiArICAgICBsb2NhbF9pcnFfZW5h YmxlKCk7Cj4+Cj4+IFRoaXMgcGFydCBsb29rcyBnb29kLiBMZXQgd2FpdCBhbmQgc2VlIGlmIENJ IGNhbGxzIG1lIGEgZm9vbC4KPiAKPiBBeWUsIHRoYXQncyB3aGF0IEknbSB3YWl0aW5nIGZvciBh cyB3ZWxsLiBQZXJzb25hbGl6ZWQgaW5zdWx0cyBmcm9tIENJIDopCj4gLUNocmlzCj4gCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==