From: Niklas Cassel <cassel@kernel.org>
To: Mikko Juhani Korhonen <mjkorhon@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
Date: Mon, 28 Apr 2025 09:44:35 +0200 [thread overview]
Message-ID: <aA8x47kjcGAsFrTZ@ryzen> (raw)
In-Reply-To: <CAAZ0mTfSFZoL_CS9s1L0JhfaoyMGJ6Up5Z9_YvU-pX05MOZ99w@mail.gmail.com>
On Fri, Apr 25, 2025 at 10:33:17PM +0300, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drives work again after regression in
> 6.9.0 when LPM was enabled, so disable it for this model.
>
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
> ---
> drivers/ata/libata-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 773799cfd443..5c2f26945d61 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4239,6 +4239,11 @@ static const struct ata_dev_quirks_entry
> __ata_dev_quirks[] = {
> { "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
>
> + /*
> + * This specific WD SATA-3 model has problems with LPM.
> + */
> + { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
> +
> /*
> * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
> * log page is accessed. Ensure we never ask for this log page with
>
> base-commit: 14a3cc755825ef7b34c986aa2786ea815023e9c5
> --
> 2.47.2
When submitting a v4,
please add:
Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
So that Sasha's scripts will see it and backport it to stable kernels.
Kind regards,
Niklas
prev parent reply other threads:[~2025-04-28 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 19:33 [PATCH v3] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Mikko Juhani Korhonen
2025-04-28 7:40 ` Niklas Cassel
2025-04-29 10:34 ` Damien Le Moal
2025-04-28 7:44 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA8x47kjcGAsFrTZ@ryzen \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjkorhon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.