From: Christoph Hellwig <hch@infradead.org>
To: Lizhi Xu <lizhi.xu@windriver.com>
Cc: hch@infradead.org, axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.lei@redhat.com,
syzbot+6af973a3b8dfd2faefdc@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V3] loop: Add sanity check for read/write_iter
Date: Mon, 28 Apr 2025 05:49:20 -0700 [thread overview]
Message-ID: <aA95UNX_BHq7GtP9@infradead.org> (raw)
In-Reply-To: <20250426021055.312912-1-lizhi.xu@windriver.com>
On Sat, Apr 26, 2025 at 10:10:55AM +0800, Lizhi Xu wrote:
> +static int loop_check_backing_file(struct file *file, blk_mode_t mode, bool change)
> +{
> + if (!file->f_op->read_iter)
> + return -EINVAL;
> +
> + if (((file->f_mode & FMODE_WRITE) ||
> + (!change && (mode & BLK_OPEN_WRITE))) &&
> + (!file->f_op->write_iter))
> + return -EINVAL;
This looks a bit odd. Both callers have the open struct file, so
we should be able to check f_mode for both cases and not need the
change flag as far as I can tell. Or did I miss something/
If for some reason we could not pass the fmode, the helper is
probably not all that useful.
next prev parent reply other threads:[~2025-04-28 12:49 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 14:08 [syzbot] [block?] BUG: unable to handle kernel NULL pointer dereference in lo_rw_aio syzbot
2025-04-25 1:19 ` [syzbot] " syzbot
2025-04-25 1:55 ` syzbot
2025-04-25 3:40 ` [PATCH] loop: Add sanity check for read/write_iter Lizhi Xu
2025-04-25 4:06 ` Zhu Yanjun
2025-04-25 4:19 ` Lizhi Xu
2025-04-25 4:20 ` Ming Lei
2025-04-25 4:33 ` Lizhi Xu
2025-04-25 5:38 ` [PATCH V2] " Lizhi Xu
2025-04-25 13:28 ` Christoph Hellwig
2025-04-26 1:50 ` Lizhi Xu
2025-04-28 12:46 ` Christoph Hellwig
2025-04-28 13:48 ` Lizhi Xu
2025-04-28 13:49 ` Christoph Hellwig
2025-04-26 2:10 ` [PATCH V3] " Lizhi Xu
2025-04-28 12:49 ` Christoph Hellwig [this message]
2025-04-28 13:42 ` Lizhi Xu
2025-04-28 13:48 ` Christoph Hellwig
2025-04-28 14:15 ` [PATCH V4] " Lizhi Xu
2025-04-28 14:26 ` Christoph Hellwig
2025-04-28 14:36 ` [PATCH V5] " Lizhi Xu
2025-05-05 6:30 ` Christoph Hellwig
2025-05-05 13:18 ` Jens Axboe
2025-05-19 15:56 ` Christian Hesse
2025-05-20 3:00 ` Lizhi Xu
2025-05-20 5:39 ` Christian Hesse
2025-05-20 6:29 ` 回复: " Xu, Lizhi
2025-05-20 6:31 ` Christian Hesse
2025-05-20 6:49 ` Xu, Lizhi
2025-05-20 6:46 ` 回复: " hch
2025-05-20 6:59 ` 回复: " Xu, Lizhi
2025-05-20 11:28 ` hch
2025-05-20 11:39 ` 回复: " Xu, Lizhi
2025-05-20 11:41 ` hch
2025-05-20 11:44 ` 回复: " Xu, Lizhi
2025-05-20 11:52 ` Xu, Lizhi
2025-05-20 12:27 ` Xu, Lizhi
2025-05-20 12:46 ` Christian Hesse
2025-05-20 12:49 ` hch
2025-05-20 13:12 ` Xu, Lizhi
2025-05-20 16:53 ` christian
2025-05-20 12:46 ` hch
2025-04-25 4:54 ` [syzbot] Re: [syzbot] [block?] BUG: unable to handle kernel NULL pointer dereference in lo_rw_aio syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA95UNX_BHq7GtP9@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=ming.lei@redhat.com \
--cc=syzbot+6af973a3b8dfd2faefdc@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.