From: Peter Chen <peter.chen@cixtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: soc@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org,
arnd@arndb.de, jassisinghbrar@gmail.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com,
maz@kernel.org, kajetan.puchalski@arm.com,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Fugang Duan <fugang.duan@cixtech.com>,
Guomin Chen <Guomin.Chen@cixtech.com>,
Gary Yang <gary.yang@cixtech.com>
Subject: Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support
Date: Thu, 17 Apr 2025 14:38:15 +0800 [thread overview]
Message-ID: <aACh17QpmWQljCZl@nchen-desktop> (raw)
In-Reply-To: <cef48ecc-94b6-40a0-9f9c-a616814878fb@kernel.org>
On 25-04-17 08:19:59, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On 15/04/2025 09:27, Peter Chen wrote:
> > CIX SKY1 SoC is high performance Armv9 SoC designed by Cixtech,
> > and Orion O6 is the motherboard launched by Radxa. See below for
> > detail:
> > https://docs.radxa.com/en/orion/o6/getting-started/introduction
> >
> > In this commit, it adds sky1 base, mailbox, clock (scmi firmware baseed)
> > and uart, and the kernel could boot up to console.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> You added several new device nodes, so obviously this is not true anymore.
>
> This is explained in submitting patches - you must drop the review when
> making substantial changes. Adding several nodes is a substantial change.
>
> > Acked-by: Fugang Duan <fugang.duan@cixtech.com>
>
> And this as well
Okay, I will delete both tags for the next submission.
--
Best regards,
Peter
next prev parent reply other threads:[~2025-04-17 6:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 7:27 [PATCH v6 00/10] arm64: Introduce CIX P1 (SKY1) SoC Peter Chen
2025-04-15 7:27 ` [PATCH v6 01/10] dt-bindings: vendor-prefixes: Add CIX Technology Group Co., Ltd Peter Chen
2025-04-15 7:27 ` [PATCH v6 02/10] dt-bindings: arm: add CIX P1 (SKY1) SoC Peter Chen
2025-04-15 7:27 ` [PATCH v6 03/10] arm64: Kconfig: add ARCH_CIX for cix silicons Peter Chen
2025-04-15 7:27 ` [PATCH v6 04/10] arm64: defconfig: Enable CIX SoC Peter Chen
2025-04-15 7:27 ` [PATCH v6 05/10] dt-bindings: mailbox: add cix,sky1-mbox Peter Chen
2025-04-16 6:34 ` Krzysztof Kozlowski
2025-04-16 8:48 ` Peter Chen
2025-04-17 6:16 ` Krzysztof Kozlowski
2025-04-15 7:27 ` [PATCH v6 06/10] mailbox: add CIX mailbox driver Peter Chen
2025-04-15 18:39 ` Sudeep Holla
2025-04-16 1:04 ` Peter Chen
2025-04-22 1:33 ` Peter Chen
2025-04-15 7:27 ` [PATCH v6 07/10] arm64: defconfig: enable CIX mailbox Peter Chen
2025-04-16 6:35 ` Krzysztof Kozlowski
2025-04-16 8:56 ` Peter Chen
2025-04-15 7:27 ` [PATCH v6 08/10] dt-bindings: clock: cix: Add CIX sky1 scmi clock id Peter Chen
2025-04-16 6:35 ` Krzysztof Kozlowski
2025-04-16 6:38 ` Krzysztof Kozlowski
2025-04-16 8:26 ` Peter Chen
2025-04-16 8:29 ` Krzysztof Kozlowski
2025-04-16 8:55 ` Peter Chen
2025-04-15 7:27 ` [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support Peter Chen
2025-04-15 13:48 ` Kajetan Puchalski
2025-04-16 1:13 ` Peter Chen
2025-04-17 6:18 ` Krzysztof Kozlowski
2025-04-17 6:37 ` Peter Chen
2025-04-17 6:58 ` Krzysztof Kozlowski
2025-04-17 8:24 ` Peter Chen
2025-04-17 6:19 ` Krzysztof Kozlowski
2025-04-17 6:38 ` Peter Chen [this message]
2025-04-15 7:27 ` [PATCH v6 10/10] MAINTAINERS: Add CIX SoC maintainer entry Peter Chen
2025-04-24 9:11 ` [PATCH v6 00/10] arm64: Introduce CIX P1 (SKY1) SoC Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aACh17QpmWQljCZl@nchen-desktop \
--to=peter.chen@cixtech.com \
--cc=Guomin.Chen@cixtech.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=gary.yang@cixtech.com \
--cc=jassisinghbrar@gmail.com \
--cc=kajetan.puchalski@arm.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.