Re: [PATCH v2] dt-bindings: powerpc: Convert fsl/pmc.txt to YAML

["J. Neuschäfer" <j.ne@posteo.net>]

On Sat, Apr 12, 2025 at 01:37:32PM -0500, Rob Herring wrote:
> On Sat, Apr 12, 2025 at 02:49:38PM +0200, J. Neuschäfer wrote:
> > This patch rewrites pmc.txt into YAML format. Descriptive texts are
> > expanded or shortened in a few places to better fit today's conventions.
> > 
> > The list of compatible strings (and combinations of them) is based on
> > existing device trees in arch/powerpc as well as compatible strings
> > already mentioned in the plain-text version of the binding.
> > 
> > One thing I didn't handle are soc-clk@... nodes as seen in
> > Documentation/devicetree/bindings/powerpc/fsl/pmc.yaml.
> > 
> > Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> > ---
> > Changes in v2:
> > - Rebase on v6.15-rc1
> > - Link to v1: https://lore.kernel.org/r/20250315-fslpmc-yaml-v1-1-10ba354a85c2@posteo.net
> > ---
> > 
> > Note: The examples include a consumer (sata@19000), to demonstrate how
> > sleep specifiers work. I've heard that "unrelated" nodes in examples are
> > generally discouraged, but I'm not sure if it's better to keep it or to
> > drop it in this example.
> 
> I'd drop. Unless you want to fix the error. There's nothing really 
> unique with how 'sleep' property works.

Okay.

> > +properties:
> > +  compatible:
> > +    oneOf:
[...]
> > +      - const: fsl,mpc8548-pmc
> > +
> > +      - const: fsl,mpc8641d-pmc
> 
> 1 enum for these 2.

Will do.


Thanks,
J. Neuschäfer