From: Breno Leitao <leitao@debian.org>
To: Zijun Hu <zijun_hu@icloud.com>
Cc: Joel Becker <jlbec@evilplan.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] configfs: Do not override creating attribute file failure in populate_attrs()
Date: Thu, 17 Apr 2025 07:57:14 -0700 [thread overview]
Message-ID: <aAEWyoqVFEknPSbH@gmail.com> (raw)
In-Reply-To: <20250415-fix_configfs-v2-2-fcd527dd1824@quicinc.com>
On Tue, Apr 15, 2025 at 08:34:26PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> populate_attrs() may override failure for creating attribute files
> by success for creating subsequent bin attribute files, and have
> wrong return value.
>
> Fix by creating bin attribute files under successfully creating
> attribute files.
>
> Fixes: 03607ace807b ("configfs: implement binary attributes")
> Cc: stable@vger.kernel.org
> Reviewed-by: Joel Becker <jlbec@evilplan.org>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2025-04-17 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 12:34 [PATCH v2 0/3] configfs: fix bugs Zijun Hu
2025-04-15 12:34 ` [PATCH v2 1/3] configfs: Delete semicolon from macro type_print() definition Zijun Hu
2025-04-17 14:58 ` Breno Leitao
2025-04-17 15:11 ` huzijun
2025-04-15 12:34 ` [PATCH v2 2/3] configfs: Do not override creating attribute file failure in populate_attrs() Zijun Hu
2025-04-17 14:57 ` Breno Leitao [this message]
2025-04-15 12:34 ` [PATCH v2 3/3] configfs: Correct error value returned by API config_item_set_name() Zijun Hu
2025-04-17 14:49 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAEWyoqVFEknPSbH@gmail.com \
--to=leitao@debian.org \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=quic_zijuhu@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.