From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Corey Minyard <corey@minyard.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH v2] ipmi:si: Move SI type information into an info structure
Date: Thu, 17 Apr 2025 18:55:35 +0300 [thread overview]
Message-ID: <aAEkdwD888tW2OUY@smile.fi.intel.com> (raw)
In-Reply-To: <20250416183614.3777003-2-corey@minyard.net>
On Wed, Apr 16, 2025 at 01:36:15PM -0500, Corey Minyard wrote:
> Andy reported:
>
> Debian clang version 19.1.7 is not happy when compiled with
> `make W=1` (note, CONFIG_WERROR=y is the default):
>
> ipmi_si_platform.c:268:15: error: cast to smaller integer type 'enum si_type'
> +from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
> 268 | io.si_type = (enum
> +si_type)device_get_match_data(&pdev->dev);
>
> The IPMI SI type is an enum that was cast into a pointer that was
> then cast into an enum again. That's not the greatest style, so
> instead create an info structure to hold the data and use that.
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-17 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 18:36 [PATCH v2] ipmi:si: Move SI type information into an info structure Corey Minyard
2025-04-17 15:55 ` Andy Shevchenko [this message]
2025-04-17 15:58 ` Andy Shevchenko
2025-04-17 20:54 ` Corey Minyard
2025-04-19 14:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAEkdwD888tW2OUY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=corey@minyard.net \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.