From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, DanieleCleri@aaeon.eu,
GaryWang@aaeon.com.tw
Subject: Re: [PATCH v3 00/10] Add pinctrl support for the AAEON UP board FPGA
Date: Thu, 17 Apr 2025 21:02:00 +0300 [thread overview]
Message-ID: <aAFCGHfkYx71ykoG@smile.fi.intel.com> (raw)
In-Reply-To: <20250416-aaeon-up-board-pinctrl-support-v3-0-f40776bd06ee@bootlin.com>
On Wed, Apr 16, 2025 at 04:08:08PM +0200, Thomas Richard wrote:
> This is the third version of this series (rebased on v6.15-rc2).
>
> The gpiolib part has been reworked, the gpiochip_add_pin_range() was
> renamed to gpiochip_add_pin_range_with_pins() and a new pins parameter was
> addded. Two stubs were created to add consecutive or sparse pin range.
>
> For the forwarder library, a namespace was added and patches were splitted
> to more simpler changes.
>
> In the pinctrl core, the function devm_pinctrl_register_mappings() was
> created.
>
> No big changes in the upboard pinctrl driver, only few fixes and
> improvements.
I reviewed it and the whole impression is very good, it seems much better in
comparison to the previous one(s).
The biggest issue I see here is the exporting the forwarder internal data type.
Most of the rest is the style related comments. Looking forward for a new
version.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-17 18:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 14:08 [PATCH v3 00/10] Add pinctrl support for the AAEON UP board FPGA Thomas Richard
2025-04-16 14:08 ` [PATCH v3 01/10] gpiolib: add support to register sparse pin range Thomas Richard
2025-04-17 7:53 ` Linus Walleij
2025-04-17 16:54 ` Andy Shevchenko
2025-04-16 14:08 ` [PATCH v3 02/10] pinctrl: core: add devm_pinctrl_register_mappings() Thomas Richard
2025-04-17 7:54 ` Linus Walleij
2025-04-17 16:07 ` kernel test robot
2025-04-17 16:13 ` Andy Shevchenko
2025-04-17 16:39 ` kernel test robot
2025-04-16 14:08 ` [PATCH v3 03/10] gpio: aggregator: move GPIO forwarder allocation in a dedicated function Thomas Richard
2025-04-17 16:56 ` Andy Shevchenko
2025-04-16 14:08 ` [PATCH v3 04/10] gpio: aggregator: refactor the code to add GPIO desc in the forwarder Thomas Richard
2025-04-17 17:16 ` Andy Shevchenko
2025-04-18 10:07 ` Thomas Richard
2025-04-16 14:08 ` [PATCH v3 05/10] gpio: aggregator: refactor the forwarder registration part Thomas Richard
2025-04-17 17:18 ` Andy Shevchenko
2025-04-16 14:08 ` [PATCH v3 06/10] gpio: aggregator: update gpiochip_fwd_setup_delay_line() parameters Thomas Richard
2025-04-17 17:23 ` Andy Shevchenko
2025-04-16 14:08 ` [PATCH v3 07/10] gpio: aggregator: export symbols of the GPIO forwarder library Thomas Richard
2025-04-17 17:33 ` Andy Shevchenko
2025-04-16 14:08 ` [PATCH v3 08/10] gpio: aggregator: handle runtime registration of gpio_desc in gpiochip_fwd Thomas Richard
2025-04-17 17:38 ` Andy Shevchenko
2025-04-17 17:40 ` Andy Shevchenko
2025-04-16 14:08 ` [PATCH v3 09/10] gpio: aggregator: add possibility to attach data to the forwarder Thomas Richard
2025-04-17 17:43 ` Andy Shevchenko
2025-04-16 14:08 ` [PATCH v3 10/10] pinctrl: Add pin controller driver for AAEON UP boards Thomas Richard
2025-04-17 7:57 ` Linus Walleij
2025-04-17 18:00 ` Andy Shevchenko
2025-04-22 14:36 ` Thomas Richard
2025-04-22 15:24 ` Andy Shevchenko
2025-04-18 21:45 ` kernel test robot
2025-04-17 18:02 ` Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-16 13:59 [PATCH v3 00/10] Add pinctrl support for the AAEON UP board FPGA Thomas Richard
2025-04-16 14:11 ` Thomas Richard
2025-04-17 7:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAFCGHfkYx71ykoG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=DanieleCleri@aaeon.eu \
--cc=GaryWang@aaeon.com.tw \
--cc=brgl@bgdev.pl \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.