From: Stafford Horne <shorne@gmail.com>
To: Sahil Siddiq <icegambit91@gmail.com>
Cc: jonas@southpole.se, stefan.kristiansson@saunalahti.fi,
sahilcdq@proton.me, linux-openrisc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] openrisc: Fix build warning in cache.c
Date: Fri, 18 Apr 2025 08:47:09 +0100 [thread overview]
Message-ID: <aAIDfcZ4XD5f6mA4@antec> (raw)
In-Reply-To: <af85b465-13e5-44e5-a0af-c7c68af7d43e@gmail.com>
On Fri, Apr 04, 2025 at 10:39:22AM +0530, Sahil Siddiq wrote:
> Hi Stafford,
>
> On 4/3/25 7:36 PM, Stafford Horne wrote:
> > [...]
> > I will just take this fix and apply it to the series (git fixup) rather than
> > take this patch as is. Also, as registers should be unsigned short, I think
> > we should change the type to that.
> >
> > I will fixup patches in place.
> >
>
> Sure thing. Will you be changing the register types as well in place with this
> fix? Let me know if I should send v2 of this patch so the changes are together.
Hi Sahil,
Sorry for delay in getting back on this. I was working on getting this patches
ready for upstreaming and noticed one thing:
---------------------------------------------------------------------------------------
./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch
---------------------------------------------------------------------------------------
WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq <icegambit91@gmail.com>' != 'Signed-off-by: Sahil Siddiq <sahilcdq@proton.me>'
total: 0 errors, 1 warnings, 102 lines checked
As you can see above the scripts/checkpatch.pl is failing with the warning
about your email and signed-off-by not matching. You can see more about it
in the FROM_SIGN_OFF_MISMATCH section of the checkpatch[0] docs.
How would you like to resolve this?
-Stafford
[0] https://docs.kernel.org/dev-tools/checkpatch.html
next prev parent reply other threads:[~2025-04-18 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 20:01 [PATCH] openrisc: Fix build warning in cache.c Sahil Siddiq
2025-04-03 14:06 ` Stafford Horne
2025-04-04 5:09 ` Sahil Siddiq
2025-04-18 7:47 ` Stafford Horne [this message]
2025-04-18 9:12 ` Sahil Siddiq
2025-04-18 10:00 ` Stafford Horne
2025-04-18 12:34 ` Sahil Siddiq
2025-04-19 5:12 ` Stafford Horne
2025-04-19 15:55 ` Sahil Siddiq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAIDfcZ4XD5f6mA4@antec \
--to=shorne@gmail.com \
--cc=icegambit91@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sahilcdq@proton.me \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.