Re: [GIT PULL] KVM changes for Linux 6.15-rc3

[Sean Christopherson <seanjc@google.com>]

On Fri, Apr 18, 2025, Paolo Bonzini wrote:
> On Fri, Apr 18, 2025 at 6:13 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> > On Fri, 18 Apr 2025 at 06:06, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >   https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
> >
> > I pulled this, but then I unpulled it, because this doesn't work for
> > me AT ALL. I get
> >
> >    ERROR: modpost: "kvm_arch_has_irq_bypass" [arch/x86/kvm/kvm-amd.ko]
> > undefined!
> >
> > when building it. I assume it's due to the change in commit
> > 73e0c567c24a ("KVM: SVM: Don't update IRTEs if APICv/AVIC is
> > disabled") but didn't check any closer.
> 
> Yep.
> 
> > I think it's literally just because that symbol isn't exported, but I
> > also suspect that the *right* fix is to make that function be an
> > inline function that doesn't *need* to be exported.
> 
> Yes, that's possible since enable_apicv is already exported. Sorry for
> the screwup.

FWIW, the fixes here came from a big series that was dependent on a much (much)
smaller series that did export kvm_arch_has_irq_bypass(), and that got missed
when these fixes were grabbed early.

But I agree that inlining the thing is a better solution.

https://lore.kernel.org/all/20250401161804.842968-2-seanjc@google.com