All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Gregory Price <gourry@gourry.net>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-team@meta.com,
	longman@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org,
	roman.gushchin@linux.dev, shakeel.butt@linux.dev,
	muchun.song@linux.dev, mkoutny@suse.com,
	akpm@linux-foundation.org
Subject: Re: [PATCH v3 0/2] vmscan: enforce mems_effective during demotion
Date: Sat, 19 Apr 2025 07:21:45 -1000	[thread overview]
Message-ID: <aAPbqbAzxsrGv0IR@slm.duckdns.org> (raw)
In-Reply-To: <20250419053824.1601470-1-gourry@gourry.net>

On Sat, Apr 19, 2025 at 01:38:22AM -0400, Gregory Price wrote:
> Change reclaim to respect cpuset.mems_effective during demotion when
> possible. Presently, reclaim explicitly ignores cpuset.mems_effective
> when demoting, which may cause the cpuset settings to violated.
> 
> Implement cpuset_node_allowed() to check the cpuset.mems_effective
> associated wih the mem_cgroup of the lruvec being scanned.
> 
> This requires renaming the existing cpuset_node_allowed() to be
> cpuset_current_now_allowed() - which is more descriptive anyway - to
> implement the new cpuset_node_allowed() which takes a target cgroup.
> 
> v3:
> - remove cgroup indirection, call cpuset directly from memcontrol
> - put mem_cgroup_node_allowed in memcontrol.c to reduce cpuset.h
>   include scope
> - return true if mems_effective is empty, and don't walk the parents
>   as recommended by Waiman Long.
> 
> Gregory Price (2):
>   cpuset: rename cpuset_node_allowed to cpuset_current_node_allowed
>   vmscan,cgroup: apply mems_effective to reclaim

From cgroup POV:

 Acked-by: Tejun Heo <tj@kernel.org>

Given that the operative changes are mostly in mm, it'd probably be best to
route through -mm, but please let me know if you wanna go through the cgroup
tree.

Thanks.

-- 
tejun

      parent reply	other threads:[~2025-04-19 17:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-19  5:38 [PATCH v3 0/2] vmscan: enforce mems_effective during demotion Gregory Price
2025-04-19  5:38 ` [PATCH v3 1/2] cpuset: rename cpuset_node_allowed to cpuset_current_node_allowed Gregory Price
2025-04-19 18:37   ` Shakeel Butt
2025-04-19  5:38 ` [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim Gregory Price
2025-04-19 18:48   ` Shakeel Butt
2025-04-20  0:14     ` Waiman Long
2025-04-21 17:39       ` Shakeel Butt
2025-04-21 22:59         ` Gregory Price
2025-04-21 23:15           ` Shakeel Butt
2025-04-21 23:58             ` Gregory Price
2025-04-22  0:10               ` Shakeel Butt
2025-04-22  0:39                 ` Waiman Long
2025-04-22  0:35               ` Waiman Long
2025-04-22  1:00                 ` Gregory Price
2025-04-22  0:10             ` Waiman Long
2025-04-22  0:16               ` Shakeel Butt
2025-04-20  0:31   ` Waiman Long
2025-04-20 23:59     ` Gregory Price
2025-04-21 23:37   ` Shakeel Butt
2025-04-19 17:21 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAPbqbAzxsrGv0IR@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=longman@redhat.com \
    --cc=mhocko@kernel.org \
    --cc=mkoutny@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.