All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Ignat Korchagin <ignat@cloudflare.com>
Subject: Re: [PATCH] crypto: public_key - Make sig/tfm local to if clause in software_key_query
Date: Sun, 20 Apr 2025 07:46:24 +0200	[thread overview]
Message-ID: <aASKMEe53YQvqiS9@wunner.de> (raw)
In-Reply-To: <Z_9gygoIHTH7A9Ma@gondor.apana.org.au>

On Wed, Apr 16, 2025 at 03:48:26PM +0800, Herbert Xu wrote:
> The recent code changes in this function triggered a false-positive
> maybe-uninitialized warning in software_key_query.  Rearrange the
> code by moving the sig/tfm variables into the if clause where they
> are actually used.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Hm, I've tried to reproduce the warning with W=1 and W=2 to no avail
(with gcc 14).  How did you trigger it?

FWIW,
Reviewed-by: Lukas Wunner <lukas@wunner.de>

I suppose this may have been introduced by 63ba4d67594a ("KEYS:
asymmetric: Use new crypto interface without scatterlists").

Thanks,

Lukas

  reply	other threads:[~2025-04-20  5:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16  7:48 [PATCH] crypto: public_key - Make sig/tfm local to if clause in software_key_query Herbert Xu
2025-04-20  5:46 ` Lukas Wunner [this message]
2025-04-20  5:48   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aASKMEe53YQvqiS9@wunner.de \
    --to=lukas@wunner.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@cloudflare.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.