All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: git@apitzsch.eu
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm8998: Add Kconfig prompt
Date: Mon, 21 Apr 2025 15:15:13 +0100	[thread overview]
Message-ID: <aAZS8XVHtw5zxD2d@opensource.cirrus.com> (raw)
In-Reply-To: <20250418-wm8998-v1-1-21c4bead9cd8@apitzsch.eu>

On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@apitzsch.eu>
> 
> Add tristate prompt to allow codec selection.
> 
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---

Generally its good to say why one wants to make the symbol
selectable, usually its to use it with simple card, although at
least historically I think simple card struggled to handle the
required set_sysclk calls for these codecs.

But I have no objection to this being exported:

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
>  sound/soc/codecs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 40bb7a1d44bcfa4c386f2eba0f475efeeedf1bdb..9ecc4bb7f75ff9fce87970d2e46ace72444e55b4 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -2479,7 +2479,7 @@ config SND_SOC_WM8997
>  	depends on MFD_WM8997 && MFD_ARIZONA
>  
>  config SND_SOC_WM8998
> -	tristate
> +	tristate "Wolfson Microelectronics WM8998 codec driver"
>  	depends on MFD_WM8998 && MFD_ARIZONA
>  
>  config SND_SOC_WM9081
> 
> ---
> base-commit: 7e74f756f5f643148ca5537bf2fee6767e4b0ed9
> change-id: 20250418-wm8998-defae73b3320
> 
> Best regards,
> -- 
> André Apitzsch <git@apitzsch.eu>
> 
> 
> 

  reply	other threads:[~2025-04-21 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18 20:22 [PATCH] ASoC: wm8998: Add Kconfig prompt André Apitzsch
2025-04-18 20:22 ` André Apitzsch via B4 Relay
2025-04-21 14:15 ` Charles Keepax [this message]
2025-04-23 11:09   ` Richard Fitzgerald
2025-04-23 19:37     ` André Apitzsch
2025-04-22 13:12 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAZS8XVHtw5zxD2d@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=git@apitzsch.eu \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.