From: Sean Christopherson <seanjc@google.com>
To: Li RongQing <lirongqing@baidu.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: Fix obsolete comment about locking for kvm_io_bus_read/write
Date: Mon, 28 Apr 2025 11:09:39 -0700 [thread overview]
Message-ID: <aA_EY8CR2kxi3X5T@google.com> (raw)
In-Reply-To: <20250418115504.17155-1-lirongqing@baidu.com>
On Fri, Apr 18, 2025, Li RongQing wrote:
> Nobody is actually calling these functions with slots_lock held.
> The srcu read lock is required.
I vote to delete the comments entirely, the srcu_dereference() precisely communicates
both what is being protected, and what provides the protection.
next prev parent reply other threads:[~2025-04-28 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 11:55 [PATCH] KVM: Fix obsolete comment about locking for kvm_io_bus_read/write Li RongQing
2025-04-28 18:09 ` Sean Christopherson [this message]
2025-04-29 2:13 ` 答复: [????] " Li,Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aA_EY8CR2kxi3X5T@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.