Re: [PATCH v2 0/3] Devres optimization with bound devices

[Danilo Krummrich <dakr@kernel.org>]

On Mon, Apr 28, 2025 at 10:39:17AM -0700, Boqun Feng wrote:
> On Mon, Apr 28, 2025 at 04:00:26PM +0200, Danilo Krummrich wrote:
> > This patch series implements a direct accessor for the data stored within
> > a Devres container for cases where we can prove that we own a reference
> > to a Device<Bound> (i.e. a bound device) of the same device that was used
> > to create the corresponding Devres container.
> > 
> > Usually, when accessing the data stored within a Devres container, it is
> > not clear whether the data has been revoked already due to the device
> > being unbound and, hence, we have to try whether the access is possible
> > and subsequently keep holding the RCU read lock for the duration of the
> > access.
> > 
> > However, when we can prove that we hold a reference to Device<Bound>
> > matching the device the Devres container has been created with, we can
> > guarantee that the device is not unbound for the duration of the
> > lifetime of the Device<Bound> reference and, hence, it is not possible
> > for the data within the Devres container to be revoked.
> > 
> > Therefore, in this case, we can bypass the atomic check and the RCU read
> > lock, which is a great optimization and simplification for drivers.
> > 
> 
> Acked-by: Boqun Feng <boqun.feng@gmail.com>
> 
> You would need to, however, change the titles for patch #2 and #3
> because there is no `Devres::access_with()` any more.

Thanks, good catch! Unless we need a v3 for something else, I'll fix it when I
apply the series.