All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uday Shankar <ushankar@purestorage.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH 6.15 2/2] selftests: ublk: remove useless 'delay_us' from 'struct dev_ctx'
Date: Mon, 21 Apr 2025 18:07:23 -0600	[thread overview]
Message-ID: <aAbduzqdp9kwazB0@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <20250421235947.715272-3-ming.lei@redhat.com>

On Tue, Apr 22, 2025 at 07:59:42AM +0800, Ming Lei wrote:
> 'delay_us' shouldn't be added to 'struct dev_ctx' since now it is
> handled by per-target command line & 'struct fault_inject_ctx'.
> 
> So remove it.
> 
> Fixes: 81586652bb1f ("selftests: ublk: add generic_06 for covering fault inject")
> Signed-off-by: Ming Lei <ming.lei@redhat.com>

Reviewed-by: Uday Shankar <ushankar@purestorage.com>

> ---
>  tools/testing/selftests/ublk/kublk.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/ublk/kublk.h b/tools/testing/selftests/ublk/kublk.h
> index 29571eb296f1..918db5cd633f 100644
> --- a/tools/testing/selftests/ublk/kublk.h
> +++ b/tools/testing/selftests/ublk/kublk.h
> @@ -86,9 +86,6 @@ struct dev_ctx {
>  	unsigned int	fg:1;
>  	unsigned int	recovery:1;
>  
> -	/* fault_inject */
> -	long long	delay_us;
> -
>  	int _evtfd;
>  	int _shmid;
>  
> -- 
> 2.47.0
> 

  reply	other threads:[~2025-04-22  0:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21 23:59 [PATCH 6.15 0/2] selftests: ublk: two fixes Ming Lei
2025-04-21 23:59 ` [PATCH 6.15 1/2] selftests: ublk: fix recover test Ming Lei
2025-04-22  0:07   ` Uday Shankar
2025-04-21 23:59 ` [PATCH 6.15 2/2] selftests: ublk: remove useless 'delay_us' from 'struct dev_ctx' Ming Lei
2025-04-22  0:07   ` Uday Shankar [this message]
2025-04-23 20:00 ` [PATCH 6.15 0/2] selftests: ublk: two fixes Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAbduzqdp9kwazB0@dev-ushankar.dev.purestorage.com \
    --to=ushankar@purestorage.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.