All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-tip-commits@vger.kernel.org,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org
Subject: Re: [tip: x86/microcode] x86/cpu: Help users notice when running old Intel microcode
Date: Tue, 22 Apr 2025 08:36:41 +0200	[thread overview]
Message-ID: <aAc4-eFLp_QeLOUu@gmail.com> (raw)
In-Reply-To: <aAc3hCVAnNLVo-Xh@gmail.com>


* Ingo Molnar <mingo@kernel.org> wrote:

> > +	if (boot_cpu_data.microcode >= m->driver_data)
> > +		return false;
> 
> Typo:
> 
>   s/microocode
>    /microcode
> 
> I've amended the commit in tip:x86/microcode accordingly, please let me 
> know if this version is fine to you too:

I've also fixed the format of the new X86_BUG_OLD_MICROCODE entry to 
the canonical format used in <asm/cpufeatures.h> (see the delta patch 
below), and pre-merged tip:x86/cpu with fixes/changes by Boris in that 
area. This avoids a tip:master conflict as well. The current commit is:

  4e2c719782a8 x86/cpu: Help users notice when running old Intel microcode

Thanks,

	Ingo

================>
 arch/x86/include/asm/cpufeatures.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
index 4d7ed8bf1770..426c7e8f0158 100644
--- a/arch/x86/include/asm/cpufeatures.h
+++ b/arch/x86/include/asm/cpufeatures.h
@@ -533,6 +533,6 @@
 #define X86_BUG_BHI			X86_BUG( 1*32+ 3) /* "bhi" CPU is affected by Branch History Injection */
 #define X86_BUG_IBPB_NO_RET		X86_BUG( 1*32+ 4) /* "ibpb_no_ret" IBPB omits return target predictions */
 #define X86_BUG_SPECTRE_V2_USER		X86_BUG( 1*32+ 5) /* "spectre_v2_user" CPU is affected by Spectre variant 2 attack between user processes */
-#define X86_BUG_OLD_MICROCODE		X86_BUG(1*32 + 6) /* "old_microcode" CPU has old microcode, it is surely vulnerable to something */
+#define X86_BUG_OLD_MICROCODE		X86_BUG( 1*32+ 6) /* "old_microcode" CPU has old microcode, it is surely vulnerable to something */
 
 #endif /* _ASM_X86_CPUFEATURES_H */


  reply	other threads:[~2025-04-22  6:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21 20:23 [tip: x86/microcode] x86/cpu: Help users notice when running old Intel microcode tip-bot2 for Dave Hansen
2025-04-22  6:30 ` Ingo Molnar
2025-04-22  6:36   ` Ingo Molnar [this message]
2025-04-22 14:05     ` Dave Hansen
  -- strict thread matches above, loose matches on Subject: below --
2025-04-22  6:36 tip-bot2 for Dave Hansen
2025-04-22  6:47 tip-bot2 for Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAc4-eFLp_QeLOUu@gmail.com \
    --to=mingo@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.