From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pei Xiao <xiaopeitux@foxmail.com>
Cc: linux-kernel@vger.kernel.org, f.fangjian@huawei.com,
robh@kernel.org, john.g.garry@oracle.com, xuwei5@hisilicon.com,
Pei Xiao <xiaopei01@kylinos.cn>
Subject: Re: [PATCH 1/2] bus: hisi_lpc: remove unused head file in hisi_lpc.c
Date: Tue, 22 Apr 2025 10:58:45 +0300 [thread overview]
Message-ID: <aAdMNb8n_wr5PwyQ@smile.fi.intel.com> (raw)
In-Reply-To: <tencent_DB84706B5135401678FD9E84CC6DB8C2450A@qq.com>
On Mon, Apr 21, 2025 at 10:06:28AM +0800, Pei Xiao wrote:
> 在 2025/4/19 23:22, Andy Shevchenko 写道:
> > On Fri, Apr 18, 2025 at 04:51:23PM +0800, xiaopeitux@foxmail.com wrote:
...
> >> linux/console.h,linux/io.h,linux/pci.h,linux/slab.h
> >> are not used, this patch removes it.
> > Definitely you haven't tested this...
>
> Sorry for that,I have tested in ARM64 platform, have no build problem,sorry for that!
Okay, but you need to follow IWYU principle. io.h is definitely used in this
file.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-22 7:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1744964101.git.xiaopei01@kylinos.cn>
2025-04-18 8:51 ` [PATCH 1/2] bus: hisi_lpc: remove unused head file in hisi_lpc.c xiaopeitux
2025-04-19 8:01 ` kernel test robot
2025-04-19 15:22 ` Andy Shevchenko
2025-04-21 2:06 ` Pei Xiao
2025-04-22 7:58 ` Andy Shevchenko [this message]
2025-04-22 11:35 ` Pei Xiao
2025-04-21 11:34 ` kernel test robot
2025-04-18 8:51 ` [PATCH 2/2] logic_pio: Add detailed comments for find_io_range() and logic_pio_trans_cpuaddr() xiaopeitux
2025-04-19 15:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAdMNb8n_wr5PwyQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=f.fangjian@huawei.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.