All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Karthik Poosa <karthik.poosa@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <anshuman.gupta@intel.com>,
	<badal.nilawar@intel.com>, <rodrigo.vivi@intel.com>,
	<riana.tauro@intel.com>
Subject: Re: [PATCH v1 2/2] drm/xe/pm: Wait for vram ready in resume
Date: Tue, 22 Apr 2025 08:48:03 -0700	[thread overview]
Message-ID: <aAe6My3TaRIrfSdM@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20250421135029.3489950-3-karthik.poosa@intel.com>

On Mon, Apr 21, 2025 at 07:20:29PM +0530, Karthik Poosa wrote:
> Add wait for vram ready during system and runtime resume.
> This wait is there in probe and is missing during resume.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>

Is this patch fixing anything, if so, we need a fixes tag for backports.

Matt

> ---
>  drivers/gpu/drm/xe/xe_pm.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 4e112fbacada..479cbccf9ed5 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -182,6 +182,10 @@ int xe_pm_resume(struct xe_device *xe)
>  	if (err)
>  		return err;
>  
> +	err = wait_for_vram_ready(xe);
> +	if (err)
> +		goto err;
> +
>  	xe_display_pm_resume_early(xe);
>  
>  	/*
> @@ -478,6 +482,10 @@ int xe_pm_runtime_resume(struct xe_device *xe)
>  		if (err)
>  			goto out;
>  
> +		err = wait_for_vram_ready(xe);
> +		if (err)
> +			goto out;
> +
>  		xe_display_pm_resume_early(xe);
>  
>  		/*
> -- 
> 2.25.1
> 

  reply	other threads:[~2025-04-22 15:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21 13:50 [PATCH v1 0/2] Wait for VRAM ready Karthik Poosa
2025-04-21 13:50 ` [PATCH v1 1/2] drm/xe: Rename wait_for_lmem_ready and make it non-static Karthik Poosa
2025-04-22 14:44   ` Riana Tauro
2025-04-21 13:50 ` [PATCH v1 2/2] drm/xe/pm: Wait for vram ready in resume Karthik Poosa
2025-04-22 15:48   ` Matthew Brost [this message]
2025-04-21 13:56 ` ✓ CI.Patch_applied: success for Wait for VRAM ready Patchwork
2025-04-21 13:56 ` ✓ CI.checkpatch: " Patchwork
2025-04-21 13:58 ` ✓ CI.KUnit: " Patchwork
2025-04-21 14:06 ` ✓ CI.Build: " Patchwork
2025-04-21 14:08 ` ✓ CI.Hooks: " Patchwork
2025-04-21 14:10 ` ✓ CI.checksparse: " Patchwork
2025-04-21 16:02 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-22 13:14 ` ✓ Xe.CI.BAT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAe6My3TaRIrfSdM@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=karthik.poosa@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.