From: Charlie Jenkins <charlie@rivosinc.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/2] package/pixman: Fix pixman compilation on riscv
Date: Tue, 22 Apr 2025 10:54:45 -0700 [thread overview]
Message-ID: <aAfX5Yn4SYrnUxNA@ghost> (raw)
In-Reply-To: <20250422085730.74c0ccff@windsurf>
On Tue, Apr 22, 2025 at 08:57:30AM +0200, Thomas Petazzoni wrote:
> Hello Charlie,
>
> On Mon, 21 Apr 2025 14:37:04 -0700
> Charlie Jenkins <charlie@rivosinc.com> wrote:
>
> > When the riscv vector extension is enabled for pixman, it assumes that
> > the kernel headers also support riscv vector. Apply a patch that
> > disables riscv vector in pixman if the Linux headers do not support
> > COMPAT_HWCAP_ISA_V which pixman requires for vector runtime detection.
> >
> > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> > Fixes: http://autobuild.buildroot.net/results/4ecdf5320716ec8b39f09fde3fcbbdcdb557f8ab/
>
> Thanks for the new iteration! One question below.
>
> > +Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> > +Fixes: 0e424031bda2 ("RISC-V floating point operations")
> > +Upstream: Pending
>
> Rather than just "Pending", we like to have here the link to the
> submission, either a like to the PR/MR, or to the mail posted on a
> mailing list. Could you provide that? No need to resend a v3 just for
> that, it can be fixed up when we apply your patch.
I had to wait for approval to open the MR and I wasn't sure how long it
would take! It ended up being very fast. Here is the MR I opened on the
pixman gitlab
https://gitlab.freedesktop.org/pixman/pixman/-/merge_requests/149.
- Charlie
>
> Thanks a lot!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-04-22 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 21:37 [Buildroot] [PATCH v2 0/2] package/pixman: Fix riscv vector support Charlie Jenkins
2025-04-21 21:37 ` [Buildroot] [PATCH v2 1/2] package/pixman: Only compile with riscv vector support when selected Charlie Jenkins
2025-04-21 21:37 ` [Buildroot] [PATCH v2 2/2] package/pixman: Fix pixman compilation on riscv Charlie Jenkins
2025-04-22 6:57 ` Thomas Petazzoni via buildroot
2025-04-22 17:54 ` Charlie Jenkins [this message]
2025-04-22 19:41 ` [Buildroot] [PATCH v2 0/2] package/pixman: Fix riscv vector support Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAfX5Yn4SYrnUxNA@ghost \
--to=charlie@rivosinc.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.