All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>,
	Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: linux-leds@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: leds: improve readibility of multicolor doc
Date: Wed, 23 Apr 2025 10:01:33 +0700	[thread overview]
Message-ID: <aAhYDY2DBxFW0yI_@archie.me> (raw)
In-Reply-To: <20250421-leds-doc-v1-1-9a32df7fc6f4@yoseli.org>

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

On Mon, Apr 21, 2025 at 06:48:10PM +0200, Jean-Michel Hautbois wrote:
> +.. code-block:: console
> +
> +    root:/sys/class/leds/multicolor:status# ls -lR

The equivalent is ``ls -lR /sys/class/leds/multicolor``.

> +    -rw-r--r--    1 root     root          4096 Oct 19 16:16 brightness
> +    -r--r--r--    1 root     root          4096 Oct 19 16:16 max_brightness
> +    -r--r--r--    1 root     root          4096 Oct 19 16:16 multi_index
> +    -rw-r--r--    1 root     root          4096 Oct 19 16:16 multi_intensity
> +
> +..
>  
> <snipped>...
>
> @@ -71,16 +79,28 @@ may want to dim the LED color group to half.  The user would write a value of
>  128 to the global brightness file then the values written to each LED will be
>  adjusted base on this value.
>  
> -cat /sys/class/leds/multicolor:status/max_brightness
> -255
> -echo 128 > /sys/class/leds/multicolor:status/brightness
> +.. code-block:: console
> +
> +    # cat /sys/class/leds/multicolor:status/max_brightness
> +    255
> +    # echo 128 > /sys/class/leds/multicolor:status/brightness
>  
> -adjusted_red_value = 128 * 138/255 = 69
> -adjusted_green_value = 128 * 43/255 = 21
> -adjusted_blue_value = 128 * 226/255 = 113
> +..
> +
> +.. code-block:: none
> +
> +    adjusted_red_value = 128 * 138/255 = 69
> +    adjusted_green_value = 128 * 43/255 = 21
> +    adjusted_blue_value = 128 * 226/255 = 113
> +
> +..

Are these adjusted values intended to be part of previous block on brightness
status? If not, I'd like to interleave these two blocks with "The adjusted
values are now::".

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-04-23  3:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21 16:48 [PATCH] Documentation: leds: improve readibility of multicolor doc Jean-Michel Hautbois
2025-04-23  3:01 ` Bagas Sanjaya [this message]
2025-04-23  5:30   ` Jean-Michel Hautbois
2025-04-24  1:44     ` Bagas Sanjaya
2025-05-06 13:15 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAhYDY2DBxFW0yI_@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jeanmichel.hautbois@yoseli.org \
    --cc=lee@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.