From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A9BFC369CB for ; Wed, 23 Apr 2025 08:48:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DFEC310E1E6; Wed, 23 Apr 2025 08:48:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="RuSTyi6A"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id BEA3189B01; Wed, 23 Apr 2025 08:48:26 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 96DE75C5D0D; Wed, 23 Apr 2025 08:46:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C11ABC4CEE2; Wed, 23 Apr 2025 08:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745398102; bh=lxI7uZm0J8wxK/ssb3AyiM5Vlyi6PpJgaX+mJgJT0qE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RuSTyi6AYiIXpMn7HmgxqlWIEs1Rqk+Xl2bKtLvaQ1s/QEdTz6EFB8lP41hGw008h 4RdP3hLk1SqU3T0NUDDd2Cp7H/wM8wkcXISxdMfO4KxZlOXQyCKpLK0GYPVEKqfwot M1dol5r/n8I425eDRzDlceRWZjAkoVxGfg9OxYNxdFDrZYLr91o5En0NsgurQUoa/H NxYTX40WhG0DP1CAz3VfvhKNXzLZ8ewNKwd3MCF3ib78BQ4za/CJu6jvv6gov6Umqp ZUu3MaYv+ONa9GvLBKe+scEeYGYVvyOIDLw3wF6aYh5y4sE0zak+/Y/7A20tIwfrIn ye5xmXT556K1w== Date: Wed, 23 Apr 2025 10:48:17 +0200 From: Danilo Krummrich To: Tvrtko Ursulin Cc: phasta@kernel.org, Lyude Paul , David Airlie , Simona Vetter , Matthew Brost , Christian =?iso-8859-1?Q?K=F6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty Message-ID: References: <0bfa746ca37de1813db22e518ffb259648d29e02.camel@mailbox.org> <5a5d4a33-2f7b-46e4-8707-7445ac3de376@igalia.com> <52574769-2120-41a1-b5dc-50a42da5dca6@igalia.com> <88f892f9-e99a-4813-830f-b3d30496ba3c@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88f892f9-e99a-4813-830f-b3d30496ba3c@igalia.com> X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: > > IMO it is better to leave it. Regardless of whether it was added because > some driver is actually operating like that, it does describe a _currently_ > workable option to avoid memory leaks. Once a better method is there, ie. > FIXME is addressed, then it can be removed or replaced. I'm not willing to sign off on encouraging drivers to rely on scheduler internals -- also not in this case, sorry. Our primary goal with the scheduler is to *remove* such broken contracts where drivers rely on scheduler internal implementation details, mess with scheduler internal data structures etc. This is clearly a step back. And AFAICT, as by now drivers either do a) or simply nothing (with the exception of the mock scheduler). Drivers can do a) in the meantime, there's no reason at all to additionally offer b).