From: Patrick Steinhardt <ps@pks.im>
To: Eli Schwartz <eschwartz@gentoo.org>
Cc: git@vger.kernel.org, Sam James <sam@gentoo.org>
Subject: Re: [PATCH 6/6] meson: only check for missing networking syms on non-Windows; add compat impls
Date: Wed, 23 Apr 2025 13:25:28 +0200 [thread overview]
Message-ID: <aAjOKBIJiNarzkYa@pks.im> (raw)
In-Reply-To: <aadfbd6b-ea1c-475e-b6a9-f1552afa06c8@gentoo.org>
On Tue, Apr 22, 2025 at 11:27:03AM -0400, Eli Schwartz wrote:
> On 4/22/25 3:31 AM, Patrick Steinhardt wrote:
> > On Mon, Apr 21, 2025 at 01:51:50PM -0400, Eli Schwartz wrote:
> > We do have compat sources for `inet_ntop()` and `inet_pton()` indeed, so
> > adding those makes sense. But we don't have a replacement for
> > `hstrerror()`, so if that function wasn't found we would error out
> > because "compat/hstrerror.c" wasn't found.
>
>
> I don't really understand what you mean by this. Of course the file will
> be found.
>
> $ grep hstrerror compat/hstrerror.c
> const char *githstrerror(int err)
>
>
> File is there. (The function name is then #defined by compat/posix.h, no
> comment.)
Oops, I somehow missed this file altogether. Please ignore this.
Patrick
next prev parent reply other threads:[~2025-04-23 11:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 17:51 [PATCH 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-21 17:51 ` [PATCH 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-24 23:48 ` Junio C Hamano
2025-04-25 0:06 ` Eli Schwartz
2025-04-21 17:51 ` [PATCH 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-22 15:27 ` Eli Schwartz
2025-04-23 11:25 ` Patrick Steinhardt [this message]
2025-04-21 20:04 ` [PATCH 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-22 0:33 ` Junio C Hamano
2025-04-22 0:58 ` Eli Schwartz
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-22 15:36 ` Eli Schwartz
2025-04-23 11:25 ` Patrick Steinhardt
2025-04-22 7:31 ` Patrick Steinhardt
2025-04-22 15:17 ` Junio C Hamano
2025-04-25 0:13 ` [PATCH v2 0/6] meson: miscellaneous system detection fixes Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-25 0:13 ` [PATCH v2 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-25 4:39 ` [PATCH v2 0/6] meson: miscellaneous system detection fixes Patrick Steinhardt
2025-04-25 5:27 ` Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 " Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-25 5:25 ` [PATCH v3 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-25 9:53 ` [PATCH v3 0/6] meson: miscellaneous system detection fixes Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAjOKBIJiNarzkYa@pks.im \
--to=ps@pks.im \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.