All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Slavko <linux@slavino.sk>, netfilter ML <netfilter@vger.kernel.org>
Subject: Re: nftables RP filter and loopback
Date: Wed, 23 Apr 2025 13:51:16 +0200	[thread overview]
Message-ID: <aAjUNAdHpiIi1Pw9@calendula> (raw)
In-Reply-To: <20250423091020.GA4038@breakpoint.cc>

On Wed, Apr 23, 2025 at 11:10:20AM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Florian, is it worth to request to include this update to -stable
> > kernels? Or you prefer the manpage note as it has been suggested?
> 
> I'll send a patch to update the nft_fib selftest to cover this,
> then make a backport of the change that doesn't include the the
> socket optimzation.
>
> When I changed it I did not realize that this fixes a bug; I would
> have split the change in two if I had.

Yes, I didn't notice either. Anyway, unless you can forecast any
issue, I'd suggest to backport the entire patch? IIRC patch is
relatively small and keeping it in sync with main could possibly help
with cherrypicking fixes.

But your way is also fine with me.

Thanks.

  reply	other threads:[~2025-04-23 11:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22  8:49 nftables RP filter and loopback Slavko
2025-04-22 11:43 ` Florian Westphal
2025-04-22 12:32   ` Slavko
2025-04-22 12:53     ` Florian Westphal
2025-04-22 13:15       ` Slavko
2025-04-22 14:15       ` Pablo Neira Ayuso
2025-04-23  9:10         ` Florian Westphal
2025-04-23 11:51           ` Pablo Neira Ayuso [this message]
2025-04-23 12:06             ` Florian Westphal
2025-04-23 20:56               ` Pablo Neira Ayuso
2025-04-23 20:58                 ` Pablo Neira Ayuso
2025-04-26  8:39   ` Slavko
2025-04-26  9:24     ` Florian Westphal
2025-04-26  9:40       ` Slavko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAjUNAdHpiIi1Pw9@calendula \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=linux@slavino.sk \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.