From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D782413B5AE for ; Wed, 23 Apr 2025 13:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745413711; cv=none; b=p9YRpdPLP5kxCv2EwFCAq5OOCVUucnm/VOagNtKjKuQB3CUy04aSd12rZm/Ko4n/3ZxmtxhNMcmkHBoM9q+f73k2YSeT0itVGeBiDirXSoMWYeKtnCvjwb+y9f+A1vtpVvPVweWj6YolXxq2I9qycRdhu6F2g67NYUD394U+hL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745413711; c=relaxed/simple; bh=V/euKjCcP+EuEZclJHRJqQhL8BiXIhmeGbSZ3k59g8o=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Y2i1rMLTQnOEFZeCvDp1XGR440DeBXFgSwKwRFj8ZCBXp60mP5hmDIQPoS6Tkyl7JtC4jVUDTa+ngrOoakXSdb5YTo/a2zWK9+kY2bcInWonnE+RWVRHIylvn01Qy9o187PlVZopgWK11c+v3racAn8L4OL1iaw8sqQD+qw8H1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SJzUmGty; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SJzUmGty" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-39ac9aea656so8104804f8f.3 for ; Wed, 23 Apr 2025 06:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745413707; x=1746018507; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=5aKGWU/nxQJ1g/GQXjmzKsRQAC1mEWy7RzAyyaBKhic=; b=SJzUmGtyqzzENuVu84/gZk73SHdxNhwQToDUfBYEUBJ/yFZmEfZ6yIkSdIhVLRyqnP 52V7TYA52s6nu3Y5LbqZoKgeKertnyzdz1lQCPOWPcEVXzcsOCRp40AZksCoVNaL5joI 1ELg0C6/4QP/RjHdPcvrWeipHyNTjyRfNuxH06c+2S/gdpx2n9Tx5rbOZWgpshgkRqWy bNuJTTgF61hxrYYIf4KKiASwZEdkVCHPC/bgv0l24ypnLgtgaBcbpeytCuhnAVJxZ9dU 86CMsMi+rP/ycDizRebXzJopVIdokBt3d2KQ2JPnTLHRePco0IFIY8r8pYt5KY+jmIcl JLCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745413707; x=1746018507; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5aKGWU/nxQJ1g/GQXjmzKsRQAC1mEWy7RzAyyaBKhic=; b=N2wxr1ZJPZxjdrmLXZ81ZEfiVi59YXQ7pLYYzGd70jDhiiWwM1A+JzNmbnO7lQBzx9 gZO+Xgivow84E2KDZ/6SlTIuFxpHWkOKVEtU0fkEnnlV9kGIJ3hiLBk/jrIRfubM8mc5 xjz/Ge+3XjoykMuQvfQBlncy+cotT0IpPgIdJ6DcvCaOCLPPPpM23vIDLCcj70h2IFPK sk9PmC9hyCQxx0ml0FlTss9tsCoOaOzA4JGAJ2prutCZKJCCcTuv1NZ0jej0zTkTo//D OAo1x7kl1U4Wp1OmYVbnRIoq4/7TTxljE720QIILA/m0fCpXC4h3jRwriVAFccX8UHhp fqHQ== X-Forwarded-Encrypted: i=1; AJvYcCWViU91lCGMbdgmtpdwNk5lvbX4v69KGUreexXI1d+W0wRHkdLhkRDo5lD48YDjMPiQwbFUlI3cmSm2xgB8GAE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx46VpcZb9FPkGQos9ejr6hwm9dzTLZJc3ZhpfzTFvy9380Ozju 7CM/K/rm5pqaPunxAS3Q4VJljtpnWJOBTfjnQOvw4vwTDtoTni+kangHhs8Ajvc= X-Gm-Gg: ASbGnctoKEQt/A4uAM3GxnJJI5rjNxBeWdADlcDehvjlZCEo9n183AUVY9MjXvpnBSw 0JPfFg1q+JVLBIwAW5ajy25tZng3R0GUTlx/FVBa4L8qcejPrLIwO5mBkXRm5/O+RnDR0Sng+4W rvfcbbAAFJsiyurr63MDg6z8Y1mJuCk/Jgt2j7spafpRXVjDHKV3B8nziqjaV1/41rTkxBLJnS5 iceYKsQ2hcVaal0AcvPtzfwqYeqf54MpiCd52+9j0OV+LuxEZVK283d41YaYd7YVIlAa1M39iCi Gn9XRPvwZLNKW3BEzZNrW14q0VtgOsZ2GmoFeMgSFlrkrp3JxkwNCs38 X-Google-Smtp-Source: AGHT+IHFDE6RSxpVFbftFmRUuMMe1z1mFI84VXLmNBo24gUTBGerWwkyU/8c7yGJzERf6IPYsxhjow== X-Received: by 2002:a5d:64ae:0:b0:38f:30a3:51fe with SMTP id ffacd0b85a97d-39efbad2f6emr13262250f8f.42.1745413707142; Wed, 23 Apr 2025 06:08:27 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39efa43330esm18445115f8f.21.2025.04.23.06.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 06:08:26 -0700 (PDT) Date: Wed, 23 Apr 2025 16:08:23 +0300 From: Dan Carpenter To: Wayne Chang Cc: JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] phy: tegra: xusb: remove a stray unlock Message-ID: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we have moved the lock into the caller. Unfortunately, when we moved the lock this unlock was left behind and it results in a double unlock. Delete it now. Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad power state tracking") Signed-off-by: Dan Carpenter --- drivers/phy/tegra/xusb-tegra186.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c index cc7b8a6a999f..23a23f2d64e5 100644 --- a/drivers/phy/tegra/xusb-tegra186.c +++ b/drivers/phy/tegra/xusb-tegra186.c @@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl) } else { clk_disable_unprepare(priv->usb2_trk_clk); } - - mutex_unlock(&padctl->lock); } static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl) -- 2.47.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AEBBC369D8 for ; Wed, 23 Apr 2025 13:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4w1SLK9MltFiKDpGvyiYwbyUAkDfK9m+Vo1v71t+U6w=; b=yuVAfnp6uMd50H c3gpht6O++mv/7KEflXtcRqkAh7VzBunWMUcMrcZnYdl6smWqXYqxeYfLPi4F/4E2wp1uqHTZbOlo HfyQvHRRa+U0+i5iA9FmGQ6voWXR1a4kgCAryYjHu3jw3uF+s5qG/uetdd7zAaLBa1squeDM6PcOl /Rhu8+iwDEmCXS4sDXtdqzH50Pd1lACFMWK4Qycx4GdxAk3w0iionxUg2rIjXkhqdsx2iy/+I6mhI ifFq3UyOuc2F1uxe+l6HTH7cbENNLnAESobnqcBBf9xcU55PUJRxiJbjiqBqICtWLfmqPuvNRxJV8 9UB+DspSd8bZ+ttANR7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7aWi-0000000Aghm-1ISa; Wed, 23 Apr 2025 13:52:36 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7Zq0-0000000AZF8-3mGF for linux-phy@lists.infradead.org; Wed, 23 Apr 2025 13:08:30 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-39c14016868so6366995f8f.1 for ; Wed, 23 Apr 2025 06:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745413707; x=1746018507; darn=lists.infradead.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=5aKGWU/nxQJ1g/GQXjmzKsRQAC1mEWy7RzAyyaBKhic=; b=MqcqV96EfthRRABocMdHSIDMJ2nte+HAvnWIosBnpxnC13yQ/Co4R67fZDh1aWEMwn RuOaGgSUQH32XTKl1wcdIN2KyrYpHxWcQRsYvCsOW7I5LG3q0zbLXZRB70Fxs0Gwhq3S dNvljpi5cl4MBvPWXZSi5HfvNVxwlQcwjlrR+6gO+NHTPauLkbKtKrzMJrhAufM5niwL QgFVvzyly1ooI4TC9U/2I7iiFkqt3W4+5swIE7xsJjP7QCYK8vaS/Pcsf0/chlj/9tOG jYNu+HDgAJA3Y9PhE+oj7ls57x6EQl1BrllZR1RQ5Dssf3yqeh4vZJIal+Ts93+YHd9t L65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745413707; x=1746018507; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5aKGWU/nxQJ1g/GQXjmzKsRQAC1mEWy7RzAyyaBKhic=; b=GCpINbOhZvSkGAbMwRh8+4HvGI8MLIUbWeRMzm7DE02qI0v+7WjJoZgk7LXUmT34sC uJLSxML9h92c4jdC+AfmAAklovKMVa4uIEgu1PStOymGi2v7Ht4p9VYTjM8jXwZKwP4e 8MmlP6mJUuLCXm8uUaXfts0G6Iiu44thvc8q57NzsaucKdh1ZzSNvnrdoKBMNhkUnvwm 3lML2eifVxT27u+N4AXnZ2AzwaFHiPhk53UF8GI9tI2e2Bpvdb3onzPt/6ffMYzdR4kk zbBg47FuhZfKN5K0Ff1923kE+fCmzF1ZSPjfjAihmWYyHHirKWW/jaQewlN/GjDAxVk4 +xqw== X-Forwarded-Encrypted: i=1; AJvYcCUov+NgFPqhl5l9/Z3vDdiVO5OUcdyr26ESC3n+r4sWYsMOjBvdQCk1T0biJnkTdh5OtAFe9du495U=@lists.infradead.org X-Gm-Message-State: AOJu0Yy8q/C2bhloECAiRSdqGRCth2+zb+j/CqoQX8bQWbJ0AAfdXawS eyKIPrPjTR9QMXFbKx5V7hABpgHd5haFfBR5s0W5xWTJ+zbOWMdAAJVlN/xYSo4= X-Gm-Gg: ASbGnctqM5kLhEBs8UtuQ5GF83D3jMvNyp24q4aeWJNrt8xaeIBgA0HHNrkrVEC1eSy YKyJSvby0jnM3gJhR7i9HmrFf9Beb5lHh8LhYKgijKzWr8aBAehDBH+MmJAK/lpePz78O8DsNLO muWurvWQfsRN4NJp0/8OcnCj4YOhBNSiS4xfUws/8HNJRgE7AT2LeD3xh4swthWWjRHBgZ+D+u9 a/sLZNRYl3L/fW2FAZnOJargVtfCLjUgOwkKbGk8dX6T4uvpXjcFUUYMBm4Vkjk6FSQnw6QQbp5 eRM51QUBwrOLUMW1Ot/LM4qSY86zgTyVju1RhJc1ridTxh3wIO70Zxk0 X-Google-Smtp-Source: AGHT+IHFDE6RSxpVFbftFmRUuMMe1z1mFI84VXLmNBo24gUTBGerWwkyU/8c7yGJzERf6IPYsxhjow== X-Received: by 2002:a5d:64ae:0:b0:38f:30a3:51fe with SMTP id ffacd0b85a97d-39efbad2f6emr13262250f8f.42.1745413707142; Wed, 23 Apr 2025 06:08:27 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39efa43330esm18445115f8f.21.2025.04.23.06.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 06:08:26 -0700 (PDT) Date: Wed, 23 Apr 2025 16:08:23 +0300 From: Dan Carpenter To: Wayne Chang Cc: JC Kuo , Vinod Koul , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] phy: tegra: xusb: remove a stray unlock Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250423_060828_949544_F86DA7F0 X-CRM114-Status: UNSURE ( 8.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we have moved the lock into the caller. Unfortunately, when we moved the lock this unlock was left behind and it results in a double unlock. Delete it now. Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad power state tracking") Signed-off-by: Dan Carpenter --- drivers/phy/tegra/xusb-tegra186.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c index cc7b8a6a999f..23a23f2d64e5 100644 --- a/drivers/phy/tegra/xusb-tegra186.c +++ b/drivers/phy/tegra/xusb-tegra186.c @@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl) } else { clk_disable_unprepare(priv->usb2_trk_clk); } - - mutex_unlock(&padctl->lock); } static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl) -- 2.47.2 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy