From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: Rob Herring <robh@kernel.org>
Cc: Nick Chan <towinchenmi@gmail.com>,
Sasha Finkelstein <fnkl.kernel@gmail.com>,
Sven Peter <sven@svenpeter.dev>, Janne Grunau <j@jannau.net>,
Neal Gompa <neal@gompa.dev>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: spmi: Add generic SPMI NVMEM
Date: Wed, 23 Apr 2025 11:46:43 -0400 [thread overview]
Message-ID: <aAkLY3TYIPG7ojwx@blossom> (raw)
In-Reply-To: <CAL_JsqKwASbUtpO=wU-16v=y8S_wLyBxnFUmQqsE8GkzCz0hDg@mail.gmail.com>
> > >> What makes this generic?
> > >>
> > >> A generic driver is great, but "generic" or "simple" bindings are
> > >> generally a mistake.
> > > There is nothing apple-specific in that driver, just re-exporting
> > > several registers as cells. If you think that it is a mistake, I can
> > > rename it to apple-pmic, or something similar.
>
> Like I said, a generic *driver* is great! I'm all for them. We should
> have more of them! Generic bindings on the other hand are generally a
> mistake. The problem is whether a generic driver works for you or not
> can evolve in either direction. You add more things like described
> below and then a generic driver doesn't work.
It sounds like the path of least resistance here is then:
1. rename the bindings to be apple m1+ (at least for now)
2. keep the driver as-is (no mfd, etc - at least for now)
3. land just that (at least for now)
Evolving the driver to share with not-Apple, or evolving the
bindings+driver to share with pre-M1, can happen in future series
if/when somebody wants to do that work.
Is this a fair understanding of the situation?
next prev parent reply other threads:[~2025-04-23 15:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 20:14 [PATCH v2 0/3] Generic SPMI NVMEM cell driver Sasha Finkelstein via B4 Relay
2025-04-17 20:14 ` Sasha Finkelstein
2025-04-17 20:14 ` [PATCH v2 1/3] dt-bindings: spmi: Add generic SPMI NVMEM Sasha Finkelstein via B4 Relay
2025-04-17 20:14 ` Sasha Finkelstein
2025-04-17 20:19 ` Alyssa Rosenzweig
2025-04-22 13:36 ` Rob Herring
2025-04-22 13:44 ` Sasha Finkelstein
2025-04-23 4:58 ` Nick Chan
2025-04-23 15:19 ` Rob Herring
2025-04-23 15:46 ` Alyssa Rosenzweig [this message]
2025-04-23 16:24 ` Sasha Finkelstein
2025-04-17 20:14 ` [PATCH v2 2/3] nvmem: Add spmi-nvmem driver Sasha Finkelstein via B4 Relay
2025-04-17 20:14 ` Sasha Finkelstein
2025-04-17 20:39 ` Alyssa Rosenzweig
2025-04-17 20:14 ` [PATCH v2 3/3] arm64: dts: apple: Add PMU NVMEM Sasha Finkelstein via B4 Relay
2025-04-17 20:14 ` Sasha Finkelstein
2025-04-17 20:20 ` Alyssa Rosenzweig
2025-04-18 4:54 ` Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAkLY3TYIPG7ojwx@blossom \
--to=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=sven@svenpeter.dev \
--cc=towinchenmi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.