From: Christoph Hellwig <hch@infradead.org>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: linux-block <linux-block@vger.kernel.org>, martin.petersen@oracle.com
Subject: Re: Block device's sysfs setting getting lost after suspend-resume cycle
Date: Wed, 23 Apr 2025 09:19:26 -0700 [thread overview]
Message-ID: <aAkTDtmOQhBP4NBa@infradead.org> (raw)
In-Reply-To: <cceea022-a5e3-97b3-62ed-7ead174565a3@applied-asynchrony.com>
So I tried to figure out how this happened, but AFAIK even
the pre atomic limits code (blk_queue_io_opt) always overrode
ra_pages. So for nvme in particular this either was introduced by
81adb863349157c67ccec871e5ae5574600c50be (HEAD)
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 28 09:53:31 2019 -0700
nvme: set physical block size and optimal I/O size
which is so old that my current compiler refuses to build that
kernel to verify it, or by the fact that you either upgraded your SSD
or the SSD firmware to set the relevant limit which was added to
nvme only a little before that.
No good fixes tag I guess, but I'll formally send out the patch anyway.
next prev parent reply other threads:[~2025-04-23 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 10:16 Block device's sysfs setting getting lost after suspend-resume cycle Holger Hoffstätte
2025-04-21 11:49 ` Christoph Hellwig
2025-04-23 6:35 ` Christoph Hellwig
2025-04-23 10:11 ` Holger Hoffstätte
2025-04-23 16:19 ` Christoph Hellwig [this message]
2025-04-23 17:05 ` Holger Hoffstätte
2025-04-24 8:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAkTDtmOQhBP4NBa@infradead.org \
--to=hch@infradead.org \
--cc=holger@applied-asynchrony.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.