From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Kent Gustavsson <kent@minoris.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Kent Gustavsson <nedo80@gmail.com>,
devicetree@vger.kernel.org,
Lukas Rauber <lukas.rauber@janitza.de>
Subject: Re: [PATCH 3/3] iio: adc: mcp3911: add reset management
Date: Wed, 23 Apr 2025 19:39:28 +0300 [thread overview]
Message-ID: <aAkXwHNWPvb_wayc@smile.fi.intel.com> (raw)
In-Reply-To: <20250423-mcp3911-fixes-v1-3-5bd0b68ec481@gmail.com>
On Wed, Apr 23, 2025 at 04:46:51PM +0200, Marcus Folkesson wrote:
> Add support for optional HW reset.
> If specified, a reset will be asserted during driver probe.
...
> + return dev_err_probe(dev, PTR_ERR(gpio_reset),
> + "Cannot get reset GPIO\n");
+ dev_printk.h
...
> + dev_dbg(dev, "gpio reset de-asserted.\n");
How useful is this?
...
> + /* Settling time after Hard Reset Mode (determined experimentally):
> + * 330 micro-seconds are too few; 470 micro-seconds are sufficient.
> + * Just in case, we add some safety factor... */
/*
* Please, fix the nulti-line comment
* style. This one can serve you as an
* example.
*/
> + fsleep(680);
Why not simply 500? or 600?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-23 16:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 14:46 [PATCH 0/3] MCP3911 fixes Marcus Folkesson
2025-04-23 14:46 ` [PATCH 1/3] iio: adc: mcp3911: fix device dependent mappings for conversion result registers Marcus Folkesson
2025-04-23 16:34 ` Andy Shevchenko
2025-04-23 14:46 ` [PATCH 2/3] dt-bindings: iio: adc: mcp3911: add reset-gpios Marcus Folkesson
2025-04-28 8:01 ` Krzysztof Kozlowski
2025-04-23 14:46 ` [PATCH 3/3] iio: adc: mcp3911: add reset management Marcus Folkesson
2025-04-23 16:39 ` Andy Shevchenko [this message]
2025-04-26 15:35 ` [PATCH 0/3] MCP3911 fixes Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAkXwHNWPvb_wayc@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.rauber@janitza.de \
--cc=marcus.folkesson@gmail.com \
--cc=nedo80@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.