All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Howard Chu <howardchu95@gmail.com>,
	Ian Rogers <irogers@google.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org, Song Liu <song@kernel.org>,
	bpf@vger.kernel.org
Subject: Re: [PATCH v4 1/2] perf trace: Implement syscall summary in BPF
Date: Wed, 23 Apr 2025 17:50:48 -0300	[thread overview]
Message-ID: <aAlSqGN9Sx4x6_sI@x1> (raw)
In-Reply-To: <aAkmY0hLXarmCSIA@google.com>

On Wed, Apr 23, 2025 at 10:41:55AM -0700, Namhyung Kim wrote:
> Hi Arnaldo,
> 
> On Wed, Apr 23, 2025 at 01:26:48PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Fri, Mar 28, 2025 at 06:46:36PM -0700, Howard Chu wrote:
> > > On Tue, Mar 25, 2025 at 9:40 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > > >      syscall            calls  errors  total       min       avg       max       stddev
> > > >                                        (msec)    (msec)    (msec)    (msec)        (%)
> > > >      --------------- --------  ------ -------- --------- --------- ---------     ------
> > > >      epoll_wait           561      0  4530.843     0.000     8.076   520.941     18.75%
> > > >      futex                693     45  4317.231     0.000     6.230   500.077     21.98%
> > > >      poll                 300      0  1040.109     0.000     3.467   120.928     17.02%
> > > >      clock_nanosleep        1      0  1000.172  1000.172  1000.172  1000.172      0.00%
> > > >      ppoll                360      0   872.386     0.001     2.423   253.275     41.91%
> > > >      epoll_pwait           14      0   384.349     0.001    27.453   380.002     98.79%
> > > >      pselect6              14      0   108.130     7.198     7.724     8.206      0.85%
> > > >      nanosleep             39      0    43.378     0.069     1.112    10.084     44.23%
> > > >      ...
> > 
> > I added the following to align sched_[gs]etaffinity,
> 
> Thanks for processing the patch and updating this.  But I'm afraid there
> are more syscalls with longer names and this is not the only place to
> print the syscall names.  Also I think we need to update length of the
> time fields.  So I prefer handling them in a separate patch later.

Fair enough, I'm leaving the patch as-is.

- Arnaldo

  reply	other threads:[~2025-04-23 20:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26  4:40 [PATCH v4 1/2] perf trace: Implement syscall summary in BPF Namhyung Kim
2025-03-26  4:40 ` [PATCH v4 2/2] perf test: Add perf trace summary test Namhyung Kim
2025-03-29  1:48   ` Howard Chu
2025-03-29  1:46 ` [PATCH v4 1/2] perf trace: Implement syscall summary in BPF Howard Chu
2025-04-23 16:19   ` Arnaldo Carvalho de Melo
2025-04-23 16:26   ` Arnaldo Carvalho de Melo
2025-04-23 17:41     ` Namhyung Kim
2025-04-23 20:50       ` Arnaldo Carvalho de Melo [this message]
2025-04-24 22:06         ` Arnaldo Carvalho de Melo
2025-04-25 21:51           ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAlSqGN9Sx4x6_sI@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=howardchu95@gmail.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.