Re: [PATCH v3 2/9] add vnc h264 encoder

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Apr 24, 2025 at 08:19:25AM +0200, Dietmar Maurer wrote:
> > > > > +        VNC_DEBUG("Could not add source to gst pipeline\n");
> > > > > +        goto error;
> > > > > +    }
> > > > > +
> > > > > +    gst_object_ref(vs->h264->convert);
> > > > > +    if (!gst_bin_add(GST_BIN(vs->h264->pipeline), vs->h264->convert)) {
> > > >
> > > > Can you use gst_bin_add_many() ?
> > >
> > > will try to use that.
> 
> I really struggle to use those functions. Documentation states
> that gst_bin_add() can fail, but gst_bin_add_many() simply ignores
> the results of gst_bin_add() (explicitly stated in the docs)? 
> 
> Do you really want to use gst_bin_add_many() anyways?

Ignoring failure in gst_bin_add_many seems like a pretty dubious design
choice to me. Given they documented that as expected behaviour I guess
there's no chance getting gstreamer to fix that.

So I'd prefer we stick with what you've got so we handle errors correctly.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|