From: Abel Vesa <abel.vesa@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bjorn Andersson" <bjorn.andersson@oss.qualcomm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Krishna Kurapati" <quic_kriskura@quicinc.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Rob Herring (Arm)" <robh@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: qcom: use modern PM macros
Date: Thu, 24 Apr 2025 10:04:12 +0300 [thread overview]
Message-ID: <aAnibPAln1kS+KHO@linaro.org> (raw)
In-Reply-To: <20250423162613.2082417-1-arnd@kernel.org>
On 25-04-23 18:26:09, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The use of the old SET_SYSTEM_SLEEP_PM_OPS/SET_RUNTIME_PM_OPS macros
> without __maybe_unused annotations causes warnings when build testing
> without CONFIG_PM:
>
> drivers/usb/dwc3/dwc3-qcom.c:421:12: error: unused function 'dwc3_qcom_suspend' [-Werror,-Wunused-function]
> 421 | static int dwc3_qcom_suspend(struct dwc3_qcom *qcom, bool wakeup)
> | ^~~~~~~~~~~~~~~~~
> drivers/usb/dwc3/dwc3-qcom.c:457:12: error: unused function 'dwc3_qcom_resume' [-Werror,-Wunused-function]
> 457 | static int dwc3_qcom_resume(struct dwc3_qcom *qcom, bool wakeup)
>
> Change these to the modern SYSTEM_SLEEP_PM_OPS/RUNTIME_PM_OPS/pm_ptr
> macros, which avoids the warnings and improves readability at the same
> time.
>
> Fixes: 1881a32fe14d ("usb: dwc3: qcom: Transition to flattened model")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
next prev parent reply other threads:[~2025-04-24 7:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 16:26 [PATCH] usb: dwc3: qcom: use modern PM macros Arnd Bergmann
2025-04-24 7:04 ` Abel Vesa [this message]
2025-04-24 23:29 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAnibPAln1kS+KHO@linaro.org \
--to=abel.vesa@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_kriskura@quicinc.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.