From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F129BC369AB for ; Thu, 24 Apr 2025 10:46:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7u5k-00064M-N5; Thu, 24 Apr 2025 06:46:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7u5X-000610-RU for qemu-devel@nongnu.org; Thu, 24 Apr 2025 06:45:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7u5U-0000QP-Hm for qemu-devel@nongnu.org; Thu, 24 Apr 2025 06:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745491547; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=OkcU0GbME87vUR2MBJKFVmNVeZrhBlcGofUrIJ2l+3U=; b=Eslhzd4v+lOFN2WstoZBk6Z+LZC/i1GMwg8ELKA7tushlcSuF30jX5nTPdohMB504vUWV+ 6zNJvyYFeYSFT/0kQXROb9flqXPT9UVAhi97rT1kXKLIHH6/fIqfd+7I/zwbIYnyTASjgF 80RWZ5t2W50c/nI5SmbNm5FDQC2QzXw= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-fcg_KHfoNvqm4ELCuSuuOA-1; Thu, 24 Apr 2025 06:45:44 -0400 X-MC-Unique: fcg_KHfoNvqm4ELCuSuuOA-1 X-Mimecast-MFC-AGG-ID: fcg_KHfoNvqm4ELCuSuuOA_1745491544 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DE7021956048; Thu, 24 Apr 2025 10:45:43 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.118]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6CB851800378; Thu, 24 Apr 2025 10:45:41 +0000 (UTC) Date: Thu, 24 Apr 2025 11:45:38 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Dietmar Maurer Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Subject: Re: [PATCH v3 2/9] add vnc h264 encoder Message-ID: References: <20250418112953.1744442-1-dietmar@proxmox.com> <20250418112953.1744442-3-dietmar@proxmox.com> <1737537002.5102.1745491162616@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1737537002.5102.1745491162616@webmail.proxmox.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.294, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Apr 24, 2025 at 12:39:22PM +0200, Dietmar Maurer wrote: > > > + g_object_set( > > > + vs->h264->gst_encoder, > > > + "tune", 4, /* zerolatency */ > > > + /* > > > + * fix for zerolatency with novnc (without, noVNC displays > > > + * green stripes) > > > + */ > > > + "threads", 1, > > > > It seems a bit dubious for QEMU to workaround VNC client bugs, as our > > server should be client agnostic. Shouldn't this flaw be fixed in noVNC > > instead. > > To be more specific, it is either a x264 encoder bug, or a web > browser (VideoEncoder api) bug. You can reproduce it with noVNC. > > Form what I found out, newer versions of x264 do not use the problematic mode at all (but we want to support older versions). Do you have examples of versions which are fixed vs broken ? It would be desirable to record something, so we know in future when we can potentially remove the workaround. NB, QEMU only aims to support the 2 most recent releases of major distros, so we don't need to care about arbitrarily old versions of x264 https://www.qemu.org/docs/master/about/build-platforms.html With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|