From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E4C28C5B9 for ; Thu, 24 Apr 2025 17:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745517404; cv=none; b=imM6M3YbkoahhYlH+fLHTKAotBRuGdO2x/rinKhzni+tpyamWkHYexpioGY1v9WQVLf679VakBLUCkg4C6PxBTO4DHnyTqZGsLjYh9MsuVs2KovRtbpyfwWl34h0RrG0S8vDqOA9vJJ+MYeMlVHt1USPLSfz/eUCzjtl/LyY7ko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745517404; c=relaxed/simple; bh=H+WVN8dXMu4VVGlDt8K/6nV5Fu+NlPxMpEedLUpBf70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IPSvPscUcet7QdK9VYef3idWjL7Y1IGUdeBi6pQPfKs1Pr4ZjwFnTAe2px+p1XcTU6VTRygaAcD0e0TvsRbnxwznEbsgy3smD6FXqchzUCNTrCm0jreOgwOglFhGpgMuaRL9i8cMaA61jNajikdC+WR88D/GESPsUgPNNw1L3wI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=HBBpqt9K; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="HBBpqt9K" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-736b34a71a1so1566284b3a.0 for ; Thu, 24 Apr 2025 10:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1745517398; x=1746122198; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KOLy/80XFfLxXJDNfbBZwCZ4HqYR8Mbf5OU8mj5q3uc=; b=HBBpqt9KIGTf8v2jOqTTdlAfcz9kwaqf7mHomP6hOLCcRR+I0n097mmb1YKNakIQuq oOcwwBNZ0MTG28FUnEgX0VCbDAGGKbyyES4CDzuRecLikf8Jyr+4puwFYpaBt3iLSMjt n05XoaDgzqjvldrrcuKVPTYsnoIGaGyXh+Gx6A4j5E3FABylK4dv8PwhtNWpIaTeyz3k Wz8iat9Z8M4S1wFKPNnXW9gTYnCcev5DNO7f4lOFR7gBR++EoS76otidVRlqUIPBYmd+ +C8q8MPSYL9xDEbraGgXX8v7w1y7RiGq6uWO7P1dDBYbWGGZJgOBcs0xWwQ7AAuJZ3gI zjwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745517398; x=1746122198; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KOLy/80XFfLxXJDNfbBZwCZ4HqYR8Mbf5OU8mj5q3uc=; b=EEj7B5k27C+HTjldMqPhUCnrQhbBEDvS4f11wy4ADdT+rhEXXURqVzNCQey/5Bwrxx mP8LWdo2w2YXTbcBp1pVG2VtIY6QnLuamTZdr8Q0g7WvErlHecVHyLNkcUegP/CgN2Ca qFNDSii36lwCR8VHt27xG9C9xCUraCT1kDTFcntoNSKa1qlhVOK9EtvQrbr5iU3XhXMa Rev5dqnl+DYtGgxqKkuYTXZnJe8qMVFLpwPRw9pWgQjIeRcvn2GW8M3yACYfHzum4jka TFnCAWJq7yGO4mDZEsezarg+9IadS4klgq8jlqk1fUiEbbLa7bZbW4SY23UR+Cj3yh1P ftkw== X-Forwarded-Encrypted: i=1; AJvYcCW+GP0bRiBDkHQ2Apmf+gq7LW8xmH2Z8czKeM/GiQz1LF1gaHPsOqtcXlYiGTigrHePzyXwA+R/HNfs@vger.kernel.org X-Gm-Message-State: AOJu0Yy3DSowBz1NLdKnJcs6e+p0eBE4ov7m+eeWiIbJZYbxJJIBfOJ8 k650skH6RE2Y8/u9N+DFTuLcU/AOZfwZ1nN8DtBxCvjChF4u2GkCgZRrJH2av7U= X-Gm-Gg: ASbGnctYYrLl3jYpy2FRXuMZL+B7E7KAVVu2i61N8H74cAONY8DGs6x1/yMrHmjBqts Drgn/hqV8nRWJ8M/Rt48zpyEXsIfoxiaj6tJ1S6Q0+CfCAy9F2NBm1JjGzXUgZmi+qqwTwgbfJC k+7AJrBkEV3Z7qRs98Gclh25kxefrm5LOwPOk8U/UqD6FGGKCpv8iZNJHsUkvsR34IFJtabtEQh 1xS8ncZMNs2pSlGhd5SJ/Ov9oxr+qgxihoYKz37Pl1AEJ4Oqp48IeuYGkWcrtw45P7FNi41dN9z rMq0epQxWd4V8eNuXIO5wyAqIPBQ5AqxauT9Y6PeqveVa5QoLY0= X-Google-Smtp-Source: AGHT+IEvwKAWcL1BB3CDYo6zsE5OWQQndt5nVMjDwtZXDpnZ2rdOW1imvzSm4O5fk1CTzTK9UpqvkQ== X-Received: by 2002:a05:6a00:1744:b0:735:d89c:4b8e with SMTP id d2e1a72fcca58-73e32fbafeemr709517b3a.5.1745517398496; Thu, 24 Apr 2025 10:56:38 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a9940esm1697082b3a.129.2025.04.24.10.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 10:56:38 -0700 (PDT) Date: Thu, 24 Apr 2025 10:56:34 -0700 From: Deepak Gupta To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, broonie@kernel.org, rick.p.edgecombe@intel.com, Zong Li , linux-riscv Subject: Re: [PATCH v12 05/28] riscv: usercfi state for task and save/restore of CSR_SSP on trap entry/exit Message-ID: References: <20250314-v5_user_cfi_series-v12-0-e51202b53138@rivosinc.com> <20250314-v5_user_cfi_series-v12-5-e51202b53138@rivosinc.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Apr 24, 2025 at 01:52:43PM +0200, Radim Krčmář wrote: >2025-04-23T17:00:29-07:00, Deepak Gupta : >> On Thu, Apr 10, 2025 at 01:04:39PM +0200, Radim Krčmář wrote: >>>2025-03-14T14:39:24-07:00, Deepak Gupta : >>>> diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/asm/thread_info.h >>>> @@ -62,6 +62,9 @@ struct thread_info { >>>> long user_sp; /* User stack pointer */ >>>> int cpu; >>>> unsigned long syscall_work; /* SYSCALL_WORK_ flags */ >>>> +#ifdef CONFIG_RISCV_USER_CFI >>>> + struct cfi_status user_cfi_state; >>>> +#endif >>> >>>I don't think it makes sense to put all the data in thread_info. >>>kernel_ssp and user_ssp is more than enough and the rest can comfortably >>>live elsewhere in task_struct. >>> >>>thread_info is supposed to be as small as possible -- just spanning >>>multiple cache-lines could be noticeable. >> >> I can change it to only include only `user_ssp`, base and size. > >No need for base and size either -- we don't touch that in the common >exception code. got it. > >> But before we go there, see below: >> >> $ pahole -C thread_info kbuild/vmlinux >> struct thread_info { >> long unsigned int flags; /* 0 8 */ >> int preempt_count; /* 8 4 */ >> >> /* XXX 4 bytes hole, try to pack */ >> >> long int kernel_sp; /* 16 8 */ >> long int user_sp; /* 24 8 */ >> int cpu; /* 32 4 */ >> >> /* XXX 4 bytes hole, try to pack */ >> >> long unsigned int syscall_work; /* 40 8 */ >> struct cfi_status user_cfi_state; /* 48 32 */ >> /* --- cacheline 1 boundary (64 bytes) was 16 bytes ago --- */ >> long unsigned int a0; /* 80 8 */ >> long unsigned int a1; /* 88 8 */ >> long unsigned int a2; /* 96 8 */ >> >> /* size: 104, cachelines: 2, members: 10 */ >> /* sum members: 96, holes: 2, sum holes: 8 */ >> /* last cacheline: 40 bytes */ >> }; >> >> If we were to remove entire `cfi_status`, it would still be 72 bytes (88 bytes >> if shadow call stack were enabled) and already spans across two cachelines. > >It has only 64 bytes of data without shadow call stack, but it wasted 8 >bytes on the holes. >a2 is somewhat an outlier that is not used most exception paths and >excluding it makes everything fit nicely even now. But we can't exclude shadow call stack. It'll lead to increased size if that config is selected. A solution has to work for all the cases and not half hearted effort. > >> if shadow call stack were enabled) and already spans across two cachelines. I >> did see the comment above that it should fit inside a cacheline. Although I >> assumed its stale comment given that it already spans across cacheline and I >> didn't see any special mention in commit messages of changes which grew this >> structure above one cacheline. So I assumed this was a stale comment. >> >> On the other hand, whenever enable/lock bits are checked, there is a high >> likelyhood that user_ssp and other fields are going to be accessed and >> thus it actually might be helpful to have it all in one cacheline during >> runtime. > >Yes, although accessing enable/lock bits will be relatively rare. >It seems better to have the overhead during thread setup, rather than on >every trap. > >> So I am not sure if its helpful sticking to the comment which already is stale. > >We could fix the holes and also use sp instead of a0 in the >new_vmalloc_check, so everything would fit better. > >We are really close to fitting into a single cache-line, so I'd prefer >if shadow stack only filled thread_info with data that is used very >often in the exception handling code. I don't get what's the big deal if it results in two cachelines. We can (re)organize data structure in a way the most frequently accessed members are together in a single cacheline. We just need to find those members. In the hot path of exception handling, I see accesses to pt_regs on stack as well. These are definitley different cacheline than thread_info. I understand the argument of one member field crossing into two cachelines can have undesired perf effects. I do not understand reasoning that thread_info exactly has to fit inside one cacheline. If this was always supposed to fit in a single cacheline, clearly this invariant isn't/wasn't maintained as changes trickled in. I would like to see what maintainers have to say or someone who did data analysis on this. > >I think we could do without user_sp in thread_info as well, so there are >other packing options. Sure, probably somewhere in task_struct. But fact of the matter is that it has to be saved/restore during exception entry/exit. But then load/store to task_struct is essentially a different cachline. Not sure what we will achieve here? > >Btw. could ssp be added to pt_regs? I had that earlier. It breaks user abi. And it was a no go. > >Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D3FAC369D5 for ; Thu, 24 Apr 2025 19:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LfpdGQFULHzvagDht5OVjCPBEpNqEipcAQlYdW+yNuY=; b=gAVbmDz2ZX+8qsCUG+iKAW9xde M00zVCUly17F/H+dJa1ZchaMNNyXmdER3OhtJL1I2GtlyQAAnZCp6gw2lqezJU15dmScVSKho/BKl GndByXTpnMrs/Ko0EBYlGpG/dHCR1vzIHxepHaZWBwcbmUR5XekYzAi2xOZlUKooa6nrCX3Q3YAh9 RqKJiWx4gtbLz5hxPuQV7Z1psJv7tqzAZzL4+7qzJi/WUtdivDCTzk0uQPbca3rZc2bBRXpeg15wl CnTYyICxPy8E0mVLDpq+CFWUj6Y7Bnwf38EqsVI5HXCskZqgrEx+Rs5baTS5ZHPXXBiMZM6+zZqco k7H8BR9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u81zf-0000000F8N3-3j9r; Thu, 24 Apr 2025 19:12:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u80oV-0000000ExYk-3skF for linux-riscv@bombadil.infradead.org; Thu, 24 Apr 2025 17:56:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=KOLy/80XFfLxXJDNfbBZwCZ4HqYR8Mbf5OU8mj5q3uc=; b=li9DBwjOMewmcbvNx22phZL+sC FQVP++WuiAxmNET4fwiLRrwD1Oc7NUbAFp9Ov08RoqDMoMP7jHf4rtEAHb39zR16vQMlbJQUnYGxK V9eatqfn3RfWJEUrv7HRy6nqqaRPbgdTG7vLbS3KHs7a08FsV1CDQP51C3ju30HUBYn+PJstR/JMI bWt8m86MdUtNZfwYj7jr3wuXt+Spxld6GQy5a3iTcmLQ8Go02VK3CK6GrDvRxC0KGlULjWrxsfcJ0 xaBPzMQe8EdrTh7/yreHmIxMWVAH/WVsY1lg6mO9BAJhsHry5IGyc6QHcAndxxGY2yxSU9lL2k02O p+prpx8A==; Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by desiato.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u80oS-0000000BtHa-2Ofq for linux-riscv@lists.infradead.org; Thu, 24 Apr 2025 17:56:42 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-7399a2dc13fso1822640b3a.2 for ; Thu, 24 Apr 2025 10:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1745517398; x=1746122198; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KOLy/80XFfLxXJDNfbBZwCZ4HqYR8Mbf5OU8mj5q3uc=; b=utwDTPBJj8oLWsjhnWv3F0MECIXf07qMHhWoZAnftBgS3gnhN2hCWS/ZKEMs0Ycrh/ Yta76/SweA2Wr4OCUk/2Rg40W0XK9grBEv7oBpHdHmOxBw1Oq6rpNXB6wouYrH51y0vW BQLm3IRuPacCFNPObZi+um7bZvFIJ9PrGxkwxC5rSMDQLWhvX2KR1DW8dHMyAOV2bHU8 pZcrHcxCpfSkDj8tpfX+QhZlZfLMHFusmaoewphsO6vCwRSlt8mOs8MvkX4hp5dgJQK7 wLyg6rx+9GwFYzSFBgrvEFDqRd96WCMsjvlA8lGjywf52mtRXTwjnDUQaUdvSwngWAxy mgmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745517398; x=1746122198; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KOLy/80XFfLxXJDNfbBZwCZ4HqYR8Mbf5OU8mj5q3uc=; b=xQoNE0nPCCm1Un8WY+32VgvEy0ebsomeCGwJ/Td9Fzty61CI27P/HBiM5A1GoT0C0H nA/ibaFQIr97Pryzg74QEFlrBw56PAVoseo0C0hQyBMZWCgjoA05whGjsvxA/DSBo/9U 3VnGDI63Kw+ac6L4wypOGqoTgToto+TTHEJTLguT8AvEZ94M4kd/eG/ADQyjbWd7ZCVu V6LHsvL3zDsIxtHFsbit+5CjaRS84mDPPHz7BaRVIgMgqIP4rwlRTy1Jf3Xm4+6AuGPo nYW1B3dYa5PXbb+zz/JQr/ty0YRlT7w2kHeJEMX5pJJ+zeiRWvuwmU1LOoptaE2T8N1y XMpA== X-Forwarded-Encrypted: i=1; AJvYcCUR4Um4/I5c243VsqTBK9WAAtOb85mSewf5/9WQhjWsZgECQ6XIFQhT6dTaLCwYVrL+Mi2qNWL5ezGsZw==@lists.infradead.org X-Gm-Message-State: AOJu0YwySgU6paf8SShppElUF1jTohwS/iUvhO+qY6vBKGcIgXEZZk+j t8Ewl15KXzUGPm/+DkXkzr34qYK4l71eba3qqIcAJ9+Dfmju6pnmfa8/Le0gsEw= X-Gm-Gg: ASbGncu493NHeuDxDab6MdF+rC7FvDIlRk935Nt2/Xjby0Ehd0YJ866N26GrK9Id69Y mKlRgjX6c7xT5NS2BRZ6/jPRaPrvo6Y8TRCCK+tX56lUEvMMisaIPpjn3sBvXAh1ivp/2KjZZTk Or5/ltzwdyee0Eq2sPLMYoGkik+Y6y24Irn3O1B4uuAFFhDoMvG4Jo1YiByK4RUlV1ecNSUc2zU Tr7iw4666uNhaKPTxqDdWMY9m8k6EVZD4WDFB0k7bodvNHjDY8XtwWTk10m9lsz9XO9MgyqsQBt V+q8rp4s24kHNjAPtV8C8RErQurZoKuKr8i131wVVZKKMW/FdPs= X-Google-Smtp-Source: AGHT+IEvwKAWcL1BB3CDYo6zsE5OWQQndt5nVMjDwtZXDpnZ2rdOW1imvzSm4O5fk1CTzTK9UpqvkQ== X-Received: by 2002:a05:6a00:1744:b0:735:d89c:4b8e with SMTP id d2e1a72fcca58-73e32fbafeemr709517b3a.5.1745517398496; Thu, 24 Apr 2025 10:56:38 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a9940esm1697082b3a.129.2025.04.24.10.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 10:56:38 -0700 (PDT) Date: Thu, 24 Apr 2025 10:56:34 -0700 From: Deepak Gupta To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, broonie@kernel.org, rick.p.edgecombe@intel.com, Zong Li , linux-riscv Subject: Re: [PATCH v12 05/28] riscv: usercfi state for task and save/restore of CSR_SSP on trap entry/exit Message-ID: References: <20250314-v5_user_cfi_series-v12-0-e51202b53138@rivosinc.com> <20250314-v5_user_cfi_series-v12-5-e51202b53138@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250424_185640_849229_3E7B6ED1 X-CRM114-Status: GOOD ( 33.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMjQsIDIwMjUgYXQgMDE6NTI6NDNQTSArMDIwMCwgUmFkaW0gS3LEjW3DocWZ IHdyb3RlOgo+MjAyNS0wNC0yM1QxNzowMDoyOS0wNzowMCwgRGVlcGFrIEd1cHRhIDxkZWJ1Z0By aXZvc2luYy5jb20+Ogo+PiBPbiBUaHUsIEFwciAxMCwgMjAyNSBhdCAwMTowNDozOVBNICswMjAw LCBSYWRpbSBLcsSNbcOhxZkgd3JvdGU6Cj4+PjIwMjUtMDMtMTRUMTQ6Mzk6MjQtMDc6MDAsIERl ZXBhayBHdXB0YSA8ZGVidWdAcml2b3NpbmMuY29tPjoKPj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9y aXNjdi9pbmNsdWRlL2FzbS90aHJlYWRfaW5mby5oIGIvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS90 aHJlYWRfaW5mby5oCj4+Pj4gQEAgLTYyLDYgKzYyLDkgQEAgc3RydWN0IHRocmVhZF9pbmZvIHsK Pj4+PiAgCWxvbmcJCQl1c2VyX3NwOwkvKiBVc2VyIHN0YWNrIHBvaW50ZXIgKi8KPj4+PiAgCWlu dAkJCWNwdTsKPj4+PiAgCXVuc2lnbmVkIGxvbmcJCXN5c2NhbGxfd29yazsJLyogU1lTQ0FMTF9X T1JLXyBmbGFncyAqLwo+Pj4+ICsjaWZkZWYgQ09ORklHX1JJU0NWX1VTRVJfQ0ZJCj4+Pj4gKwlz dHJ1Y3QgY2ZpX3N0YXR1cwl1c2VyX2NmaV9zdGF0ZTsKPj4+PiArI2VuZGlmCj4+Pgo+Pj5JIGRv bid0IHRoaW5rIGl0IG1ha2VzIHNlbnNlIHRvIHB1dCBhbGwgdGhlIGRhdGEgaW4gdGhyZWFkX2lu Zm8uCj4+Pmtlcm5lbF9zc3AgYW5kIHVzZXJfc3NwIGlzIG1vcmUgdGhhbiBlbm91Z2ggYW5kIHRo ZSByZXN0IGNhbiBjb21mb3J0YWJseQo+Pj5saXZlIGVsc2V3aGVyZSBpbiB0YXNrX3N0cnVjdC4K Pj4+Cj4+PnRocmVhZF9pbmZvIGlzIHN1cHBvc2VkIHRvIGJlIGFzIHNtYWxsIGFzIHBvc3NpYmxl IC0tIGp1c3Qgc3Bhbm5pbmcKPj4+bXVsdGlwbGUgY2FjaGUtbGluZXMgY291bGQgYmUgbm90aWNl YWJsZS4KPj4KPj4gSSBjYW4gY2hhbmdlIGl0IHRvIG9ubHkgaW5jbHVkZSBvbmx5IGB1c2VyX3Nz cGAsIGJhc2UgYW5kIHNpemUuCj4KPk5vIG5lZWQgZm9yIGJhc2UgYW5kIHNpemUgZWl0aGVyIC0t IHdlIGRvbid0IHRvdWNoIHRoYXQgaW4gdGhlIGNvbW1vbgo+ZXhjZXB0aW9uIGNvZGUuCgpnb3Qg aXQuCgo+Cj4+IEJ1dCBiZWZvcmUgd2UgZ28gdGhlcmUsIHNlZSBiZWxvdzoKPj4KPj4gJCBwYWhv bGUgLUMgdGhyZWFkX2luZm8ga2J1aWxkL3ZtbGludXgKPj4gc3RydWN0IHRocmVhZF9pbmZvIHsK Pj4gICAgICAgICAgbG9uZyB1bnNpZ25lZCBpbnQgICAgICAgICAgZmxhZ3M7ICAgICAgICAgICAg ICAgIC8qICAgICAwICAgICA4ICovCj4+ICAgICAgICAgIGludCAgICAgICAgICAgICAgICAgICAg ICAgIHByZWVtcHRfY291bnQ7ICAgICAgICAvKiAgICAgOCAgICAgNCAqLwo+Pgo+PiAgICAgICAg ICAvKiBYWFggNCBieXRlcyBob2xlLCB0cnkgdG8gcGFjayAqLwo+Pgo+PiAgICAgICAgICBsb25n IGludCAgICAgICAgICAgICAgICAgICBrZXJuZWxfc3A7ICAgICAgICAgICAgLyogICAgMTYgICAg IDggKi8KPj4gICAgICAgICAgbG9uZyBpbnQgICAgICAgICAgICAgICAgICAgdXNlcl9zcDsgICAg ICAgICAgICAgIC8qICAgIDI0ICAgICA4ICovCj4+ICAgICAgICAgIGludCAgICAgICAgICAgICAg ICAgICAgICAgIGNwdTsgICAgICAgICAgICAgICAgICAvKiAgICAzMiAgICAgNCAqLwo+Pgo+PiAg ICAgICAgICAvKiBYWFggNCBieXRlcyBob2xlLCB0cnkgdG8gcGFjayAqLwo+Pgo+PiAgICAgICAg ICBsb25nIHVuc2lnbmVkIGludCAgICAgICAgICBzeXNjYWxsX3dvcms7ICAgICAgICAgLyogICAg NDAgICAgIDggKi8KPj4gICAgICAgICAgc3RydWN0IGNmaV9zdGF0dXMgICAgICAgICAgdXNlcl9j Zmlfc3RhdGU7ICAgICAgIC8qICAgIDQ4ICAgIDMyICovCj4+ICAgICAgICAgIC8qIC0tLSBjYWNo ZWxpbmUgMSBib3VuZGFyeSAoNjQgYnl0ZXMpIHdhcyAxNiBieXRlcyBhZ28gLS0tICovCj4+ICAg ICAgICAgIGxvbmcgdW5zaWduZWQgaW50ICAgICAgICAgIGEwOyAgICAgICAgICAgICAgICAgICAv KiAgICA4MCAgICAgOCAqLwo+PiAgICAgICAgICBsb25nIHVuc2lnbmVkIGludCAgICAgICAgICBh MTsgICAgICAgICAgICAgICAgICAgLyogICAgODggICAgIDggKi8KPj4gICAgICAgICAgbG9uZyB1 bnNpZ25lZCBpbnQgICAgICAgICAgYTI7ICAgICAgICAgICAgICAgICAgIC8qICAgIDk2ICAgICA4 ICovCj4+Cj4+ICAgICAgICAgIC8qIHNpemU6IDEwNCwgY2FjaGVsaW5lczogMiwgbWVtYmVyczog MTAgKi8KPj4gICAgICAgICAgLyogc3VtIG1lbWJlcnM6IDk2LCBob2xlczogMiwgc3VtIGhvbGVz OiA4ICovCj4+ICAgICAgICAgIC8qIGxhc3QgY2FjaGVsaW5lOiA0MCBieXRlcyAqLwo+PiB9Owo+ Pgo+PiBJZiB3ZSB3ZXJlIHRvIHJlbW92ZSBlbnRpcmUgYGNmaV9zdGF0dXNgLCBpdCB3b3VsZCBz dGlsbCBiZSA3MiBieXRlcyAoODggYnl0ZXMKPj4gaWYgc2hhZG93IGNhbGwgc3RhY2sgd2VyZSBl bmFibGVkKSBhbmQgYWxyZWFkeSBzcGFucyBhY3Jvc3MgdHdvIGNhY2hlbGluZXMuCj4KPkl0IGhh cyBvbmx5IDY0IGJ5dGVzIG9mIGRhdGEgd2l0aG91dCBzaGFkb3cgY2FsbCBzdGFjaywgYnV0IGl0 IHdhc3RlZCA4Cj5ieXRlcyBvbiB0aGUgaG9sZXMuCj5hMiBpcyBzb21ld2hhdCBhbiBvdXRsaWVy IHRoYXQgaXMgbm90IHVzZWQgbW9zdCBleGNlcHRpb24gcGF0aHMgYW5kCj5leGNsdWRpbmcgaXQg bWFrZXMgZXZlcnl0aGluZyBmaXQgbmljZWx5IGV2ZW4gbm93LgoKQnV0IHdlIGNhbid0IGV4Y2x1 ZGUgc2hhZG93IGNhbGwgc3RhY2suIEl0J2xsIGxlYWQgdG8gaW5jcmVhc2VkIHNpemUgaWYgdGhh dApjb25maWcgaXMgc2VsZWN0ZWQuIEEgc29sdXRpb24gaGFzIHRvIHdvcmsgZm9yIGFsbCB0aGUg Y2FzZXMgYW5kIG5vdCBoYWxmCmhlYXJ0ZWQgZWZmb3J0LgoKPgo+PiBpZiBzaGFkb3cgY2FsbCBz dGFjayB3ZXJlIGVuYWJsZWQpIGFuZCBhbHJlYWR5IHNwYW5zIGFjcm9zcyB0d28gY2FjaGVsaW5l cy4gSQo+PiBkaWQgc2VlIHRoZSBjb21tZW50IGFib3ZlIHRoYXQgaXQgc2hvdWxkIGZpdCBpbnNp ZGUgYSBjYWNoZWxpbmUuIEFsdGhvdWdoIEkKPj4gYXNzdW1lZCBpdHMgc3RhbGUgY29tbWVudCBn aXZlbiB0aGF0IGl0IGFscmVhZHkgc3BhbnMgYWNyb3NzIGNhY2hlbGluZSBhbmQgSQo+PiBkaWRu J3Qgc2VlIGFueSBzcGVjaWFsIG1lbnRpb24gaW4gY29tbWl0IG1lc3NhZ2VzIG9mIGNoYW5nZXMg d2hpY2ggZ3JldyB0aGlzCj4+IHN0cnVjdHVyZSBhYm92ZSBvbmUgY2FjaGVsaW5lLiBTbyBJIGFz c3VtZWQgdGhpcyB3YXMgYSBzdGFsZSBjb21tZW50Lgo+Pgo+PiBPbiB0aGUgb3RoZXIgaGFuZCwg d2hlbmV2ZXIgZW5hYmxlL2xvY2sgYml0cyBhcmUgY2hlY2tlZCwgdGhlcmUgaXMgYSBoaWdoCj4+ IGxpa2VseWhvb2QgdGhhdCB1c2VyX3NzcCBhbmQgb3RoZXIgZmllbGRzIGFyZSBnb2luZyB0byBi ZSBhY2Nlc3NlZCBhbmQKPj4gdGh1cyBpdCBhY3R1YWxseSBtaWdodCBiZSBoZWxwZnVsIHRvIGhh dmUgaXQgYWxsIGluIG9uZSBjYWNoZWxpbmUgZHVyaW5nCj4+IHJ1bnRpbWUuCj4KPlllcywgYWx0 aG91Z2ggYWNjZXNzaW5nIGVuYWJsZS9sb2NrIGJpdHMgd2lsbCBiZSByZWxhdGl2ZWx5IHJhcmUu Cj5JdCBzZWVtcyBiZXR0ZXIgdG8gaGF2ZSB0aGUgb3ZlcmhlYWQgZHVyaW5nIHRocmVhZCBzZXR1 cCwgcmF0aGVyIHRoYW4gb24KPmV2ZXJ5IHRyYXAuCj4KPj4gU28gSSBhbSBub3Qgc3VyZSBpZiBp dHMgaGVscGZ1bCBzdGlja2luZyB0byB0aGUgY29tbWVudCB3aGljaCBhbHJlYWR5IGlzIHN0YWxl Lgo+Cj5XZSBjb3VsZCBmaXggdGhlIGhvbGVzIGFuZCBhbHNvIHVzZSBzcCBpbnN0ZWFkIG9mIGEw IGluIHRoZQo+bmV3X3ZtYWxsb2NfY2hlY2ssIHNvIGV2ZXJ5dGhpbmcgd291bGQgZml0IGJldHRl ci4KPgo+V2UgYXJlIHJlYWxseSBjbG9zZSB0byBmaXR0aW5nIGludG8gYSBzaW5nbGUgY2FjaGUt bGluZSwgc28gSSdkIHByZWZlcgo+aWYgc2hhZG93IHN0YWNrIG9ubHkgZmlsbGVkIHRocmVhZF9p bmZvIHdpdGggZGF0YSB0aGF0IGlzIHVzZWQgdmVyeQo+b2Z0ZW4gaW4gdGhlIGV4Y2VwdGlvbiBo YW5kbGluZyBjb2RlLgoKSSBkb24ndCBnZXQgd2hhdCdzIHRoZSBiaWcgZGVhbCBpZiBpdCByZXN1 bHRzIGluIHR3byBjYWNoZWxpbmVzLiBXZSBjYW4KKHJlKW9yZ2FuaXplIGRhdGEgc3RydWN0dXJl IGluIGEgd2F5IHRoZSBtb3N0IGZyZXF1ZW50bHkgYWNjZXNzZWQgbWVtYmVycyBhcmUKdG9nZXRo ZXIgaW4gYSBzaW5nbGUgY2FjaGVsaW5lLiBXZSBqdXN0IG5lZWQgdG8gZmluZCB0aG9zZSBtZW1i ZXJzLgoKSW4gdGhlIGhvdCBwYXRoIG9mIGV4Y2VwdGlvbiBoYW5kbGluZywgSSBzZWUgYWNjZXNz ZXMgdG8gcHRfcmVncyBvbiBzdGFjayBhcwp3ZWxsLiBUaGVzZSBhcmUgZGVmaW5pdGxleSBkaWZm ZXJlbnQgY2FjaGVsaW5lIHRoYW4gdGhyZWFkX2luZm8uCgpJIHVuZGVyc3RhbmQgdGhlIGFyZ3Vt ZW50IG9mIG9uZSBtZW1iZXIgZmllbGQgY3Jvc3NpbmcgaW50byB0d28gY2FjaGVsaW5lcyBjYW4K aGF2ZSB1bmRlc2lyZWQgcGVyZiBlZmZlY3RzLiBJIGRvIG5vdCB1bmRlcnN0YW5kIHJlYXNvbmlu ZyB0aGF0IHRocmVhZF9pbmZvCmV4YWN0bHkgaGFzIHRvIGZpdCBpbnNpZGUgb25lIGNhY2hlbGlu ZS4KCklmIHRoaXMgd2FzIGFsd2F5cyBzdXBwb3NlZCB0byBmaXQgaW4gYSBzaW5nbGUgY2FjaGVs aW5lLCBjbGVhcmx5IHRoaXMKaW52YXJpYW50IGlzbid0L3dhc24ndCBtYWludGFpbmVkIGFzIGNo YW5nZXMgdHJpY2tsZWQgaW4uIEkgd291bGQgbGlrZSB0byBzZWUKd2hhdCBtYWludGFpbmVycyBo YXZlIHRvIHNheSBvciBzb21lb25lIHdobyBkaWQgZGF0YSBhbmFseXNpcyBvbiB0aGlzLgoKCj4K PkkgdGhpbmsgd2UgY291bGQgZG8gd2l0aG91dCB1c2VyX3NwIGluIHRocmVhZF9pbmZvIGFzIHdl bGwsIHNvIHRoZXJlIGFyZQo+b3RoZXIgcGFja2luZyBvcHRpb25zLgoKU3VyZSwgcHJvYmFibHkg c29tZXdoZXJlIGluIHRhc2tfc3RydWN0LiBCdXQgZmFjdCBvZiB0aGUgbWF0dGVyIGlzIHRoYXQg aXQgaGFzCnRvIGJlIHNhdmVkL3Jlc3RvcmUgZHVyaW5nIGV4Y2VwdGlvbiBlbnRyeS9leGl0LiBC dXQgdGhlbiBsb2FkL3N0b3JlIHRvCnRhc2tfc3RydWN0IGlzIGVzc2VudGlhbGx5IGEgZGlmZmVy ZW50IGNhY2hsaW5lLiBOb3Qgc3VyZSB3aGF0IHdlIHdpbGwgYWNoaWV2ZQpoZXJlPwoKPgo+QnR3 LiBjb3VsZCBzc3AgYmUgYWRkZWQgdG8gcHRfcmVncz8KCkkgaGFkIHRoYXQgZWFybGllci4gSXQg YnJlYWtzIHVzZXIgYWJpLiBBbmQgaXQgd2FzIGEgbm8gZ28uCgo+Cj5UaGFua3MuCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWls aW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==