From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16D2A284672 for ; Thu, 24 Apr 2025 16:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511635; cv=none; b=sr1FhArDzYzm1Ys11o0JidkYtAFyFvrvsR7mzMEZy2a9YnThMlSkngYnEHPUgh6xWyUHjDTWbd3J56/N2rRaiMu6vvEp0a9Kc1SYrM+1f1dCGKdC+9cmS1fzDgx5CvS3GQBclMuHzvTB3kUIb73kFdIeiHHmoTygq4xIrfwXODM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745511635; c=relaxed/simple; bh=InCEXlPry0Shz7qVuW3hH1vNAWeUV5R/D7hsRSK5cXk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BmHln913krcmiMpjwk3O8TEaaU1eOy/abcBsIXQmavT3pTXujjCKBIlVD7W9tuoakMxz5zkge/bh2Tb/mtzSxeH+cNPFBRhVUNEuBLBr9F1XsQXhyjnu3vLA8U7JoHnqz2Rsfo7uGzXGYqmBNserF4Gx5n+7wmDoaN94sFBmt44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rMdsQgZ9; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rMdsQgZ9" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2240b4de12bso19025235ad.2 for ; Thu, 24 Apr 2025 09:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745511633; x=1746116433; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AjA0zRqOdoO65aeGmUVGM27lVhB2Fk68FwOzncHTk4I=; b=rMdsQgZ9PGjTsS+tEjtyRiXuk08i4ku/GiVOjbm8rSjCfY4Czjr28w2JqWMIsgkZc7 Mx6h9K5OEMXERb/9WTH1MmRwXk/NFk5W8Nd6hpSGAtn+GQRNdIFdK9fPDGTv3bpx+Kjq WiEOBTDMAxiCLRZ7Xg3ekjZX7g/pz3zogzUE8gxEnWPTS/MqgCKmPMu7rtSE0sc/nTcS CwjcOxIB2FR4/YbadvC1JgfKmX9mxEGob6CQjOwVJlwnflDQoL12x81n9h52BmK4WkJO l+ICwq2gNX/MMaQ+ILcDzTc2htxhjvBGIvmcpWLO1KIdK5K39xPMolpHCjnX9gU5nsou i9XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745511633; x=1746116433; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AjA0zRqOdoO65aeGmUVGM27lVhB2Fk68FwOzncHTk4I=; b=rwFfFUhuMuwNfRQc1RZku+75WKfWRbFpMfUGMHc5P3i0fx0YavKFUsS+FkgnPoymIL L5frqFa1XFSF4SG5jME3azhqRsAszuFIdJ3/7myNsHkBphsQ0mcY1izBLTiA/QiBJiDV D1KhhB9yOWEV9L8fbDqh1qfICPbwMr4i3S/RNZf/oQ6i8zYCqW4UUAZAHtzvjf4Fu0bP vyPyZhVrBhw9NBWQ07Z1D0RBwpnJA4P/hYjEc+6SubZdKsvazqAuK0Oz8MvW+konelj5 4g8HBiWqg8frRjFPbrJfisdcQyWNgEWbm0GIdEzZozkTQGsr8BZdbqn2sfxLpZZyAcGA OLFQ== X-Forwarded-Encrypted: i=1; AJvYcCVtBgU4BCRxx7A8e3RuVg+PX4yJ+u4A4G6lv/u5CVSxVQHrYmRwmFKtkcCB2Dcl5gUdGvtZPQ9w0Gk=@vger.kernel.org X-Gm-Message-State: AOJu0YxQygRS5PgIO2XhOY9A5xlr1PIzrWiXUwVD5h7jZq1AMY+6xkFm yhm1+rln5tcjCimhBEb7thSLbFH1C6TYM084+5FyXdRPf5IdFcOdsWlK5HjKyQ== X-Gm-Gg: ASbGncsH6UGgHGgA/uVGjwqgvkdbHJYzWeLgxtattvLZP9hw8Z3232naNlqWsUHpMSl Mhbbryt1Jp6I7l3bTyfd10P6EltmdiMBcAZzEI+K5T2d5f6X8qOYOmJSvhOsU2kbpusByTpzgwC wRaPn5nUgpoJKs1UvXyGw5VPgIRxBggCcsUiSnZW+qo/06eqEhrkr2WxRR1CN1YdECNzwv7OY3B QoIp/9Ar/1SwxhTtKTpM1ado3A7jPaSJ7lNrXTpOaNr5GFqt2F26oOY4NtXjiQH6khS7kcsUDsV XYPlz1R0lB7XgtebZ85lOZOgizf7PYk13PG1pb9zqECRcHSUzWoMTRhhm30FnPMsEMt8KmjPtwQ z7w== X-Google-Smtp-Source: AGHT+IG8P6+pJNOxYWYGXFazufP063CNc7E1r2Vnv478yECDez1ity5Va93DLn+NqSzjAaI191FlTA== X-Received: by 2002:a17:90a:d88d:b0:2ff:4f04:4261 with SMTP id 98e67ed59e1d1-309f5724fcemr351652a91.34.1745511632805; Thu, 24 Apr 2025 09:20:32 -0700 (PDT) Received: from google.com (30.176.125.34.bc.googleusercontent.com. [34.125.176.30]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef03bb7fsm1597107a91.9.2025.04.24.09.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 09:20:31 -0700 (PDT) Date: Thu, 24 Apr 2025 16:20:25 +0000 From: Benson Leung To: Andrei Kuchynski Cc: Heikki Krogerus , Greg Kroah-Hartman , Jameson Thies , Abhishek Pandit-Subedi , Benson Leung , Dmitry Baryshkov , Diogo Ivo , Pooja Katiyar , Madhu M , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] usb: typec: ucsi: displayport: Fix NULL pointer access Message-ID: References: <20250424084429.3220757-1-akuchynski@chromium.org> <20250424084429.3220757-3-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yN6CB+ZP4HAxLcf/" Content-Disposition: inline In-Reply-To: <20250424084429.3220757-3-akuchynski@chromium.org> --yN6CB+ZP4HAxLcf/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 24, 2025 at 08:44:29AM +0000, Andrei Kuchynski wrote: > This patch ensures that the UCSI driver waits for all pending tasks in the > ucsi_displayport_work workqueue to finish executing before proceeding with > the partner removal. >=20 > Cc: stable@vger.kernel.org > Fixes: af8622f6a585 ("usb: typec: ucsi: Support for DisplayPort alt mode") > Signed-off-by: Andrei Kuchynski > Reviewed-by: Heikki Krogerus Reviewed-by: Benson Leung > --- > drivers/usb/typec/ucsi/displayport.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/usb/typec/ucsi/displayport.c b/drivers/usb/typec/ucs= i/displayport.c > index acd053d4e38c..8aae80b457d7 100644 > --- a/drivers/usb/typec/ucsi/displayport.c > +++ b/drivers/usb/typec/ucsi/displayport.c > @@ -299,6 +299,8 @@ void ucsi_displayport_remove_partner(struct typec_alt= mode *alt) > if (!dp) > return; > =20 > + cancel_work_sync(&dp->work); > + > dp->data.conf =3D 0; > dp->data.status =3D 0; > dp->initialized =3D false; > --=20 > 2.49.0.805.g082f7c87e0-goog >=20 --yN6CB+ZP4HAxLcf/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCaApkyQAKCRBzbaomhzOw wmZOAQCJHSNgJn3fio8LE2QNBerK0r8asdS4fi/alefs3cAcqgD/Y50z1pEaIDoS Ne3XXI4RGAwgX1RNf4VOHCVJcSyczwk= =L2jV -----END PGP SIGNATURE----- --yN6CB+ZP4HAxLcf/--