Re: [PATCH] media: ov08x40: Fix the horizontal flip control

[Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>]

On Fri, Apr 25, 2025 at 12:33:25PM +0800, Hao Yao wrote:
> The datasheet of ov08x40 doesn't match the hardware behavior.
> 0x3821[2] == 1 is the original state and 0 the horizontal flip enabled.
> 
> Signed-off-by: Hao Yao <hao.yao@intel.com>

Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

Regards
Stanislaw

> ---
>  drivers/media/i2c/ov08x40.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c
> index cf0e41fc3071..17112c02408a 100644
> --- a/drivers/media/i2c/ov08x40.c
> +++ b/drivers/media/i2c/ov08x40.c
> @@ -1627,7 +1627,7 @@ static int ov08x40_set_ctrl_hflip(struct ov08x40 *ov08x, u32 ctrl_val)
>  
>  	return ov08x40_write_reg(ov08x, OV08X40_REG_MIRROR,
>  				 OV08X40_REG_VALUE_08BIT,
> -				 ctrl_val ? val | BIT(2) : val & ~BIT(2));
> +				 ctrl_val ? val & ~BIT(2) : val | BIT(2));
>  }
>  
>  static int ov08x40_set_ctrl_vflip(struct ov08x40 *ov08x, u32 ctrl_val)
> -- 
> 2.43.0
> 
>