From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C75EFC369C2 for ; Fri, 25 Apr 2025 12:22:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8I3N-0002uK-94; Fri, 25 Apr 2025 08:21:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8I3J-0002tq-G1 for qemu-devel@nongnu.org; Fri, 25 Apr 2025 08:21:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8I3F-00043M-H5 for qemu-devel@nongnu.org; Fri, 25 Apr 2025 08:21:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745583663; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=M1XejkxOGT0jUglbBcGYwTLhoPHU4a47UtGPNVY+fqU=; b=FUNUf6Y6/ZqAynkHGUrUoNTumBnQNLGtz/Jv4B+tvA1m7h8zFne32hy6poP0XOZdjcq59M xf+uVQwzrRup/6yJ7jms51dXO0M6mioHSmlAbjQI4OU0/HNr5cPijjQUSPZ5PLnLDH13GK jcbsrNgwyY7wQOSApDhwI2nHlfRGF3g= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-aGlUK1UUOWuW52oxUJMR3A-1; Fri, 25 Apr 2025 08:20:59 -0400 X-MC-Unique: aGlUK1UUOWuW52oxUJMR3A-1 X-Mimecast-MFC-AGG-ID: aGlUK1UUOWuW52oxUJMR3A_1745583657 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C2D0F1956087; Fri, 25 Apr 2025 12:20:55 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.69]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 34B68180045B; Fri, 25 Apr 2025 12:20:47 +0000 (UTC) Date: Fri, 25 Apr 2025 13:20:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Michael S. Tsirkin" Cc: Akihiko Odaki , Jason Wang , Dmitry Fleytman , Sriram Yagnaraman , Luigi Rizzo , Giuseppe Lettieri , Vincenzo Maffione , Andrew Melnychenko , Yuri Benditovich , Paolo Bonzini , Eduardo Habkost , Markus Armbruster , Michael Roth , Marcel Apfelbaum , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Yanan Wang , Zhao Liu , Lei Yang , BALATON Zoltan , qemu-devel@nongnu.org, devel@daynix.com Subject: Re: [PATCH v6 0/4] virtio: Convert feature properties to OnOffAuto Message-ID: References: <20250306-virtio-v6-0-1235eab776d9@daynix.com> <20250425081234-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250425081234-mutt-send-email-mst@kernel.org> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.314, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Apr 25, 2025 at 08:14:13AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 06, 2025 at 03:16:26PM +0900, Akihiko Odaki wrote: > > This series was spun off from: > > "[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto" > > (https://patchew.org/QEMU/20240714-auto-v3-0-e27401aabab3@daynix.com/) > > > > Some features are not always available with vhost. Legacy features are > > not available with vp_vdpa in particular. virtio devices used to disable > > them when not available even if the corresponding properties were > > explicitly set to "on". > > > > QEMU already has OnOffAuto type, which includes the "auto" value to let > > it automatically decide the effective value. Convert feature properties > > to OnOffAuto and set them "auto" by default to utilize it. This allows > > QEMU to report an error if they are set "on" and the corresponding > > features are not available. > > > > Signed-off-by: Akihiko Odaki > > > Marcus, Paolo, Daniel, Eduardo, any feedback on the QOM bits? I've said on every previous version that I don't think we should be changing OnOffAuto to secretly accept bool values. That is bypassing QAPI schema definitions with a special code hack. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|