From: Sakari Ailus <sakari.ailus@iki.fi>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Umang Jain <umang.jain@ideasonboard.com>
Subject: Re: [PATCH] media: imx335: Use correct register width for HNUM
Date: Fri, 25 Apr 2025 07:58:46 +0000 [thread overview]
Message-ID: <aAtAtp2epJCs0RaN@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20250422122052.12601-1-kieran.bingham@ideasonboard.com>
Hi Kieran,
On Tue, Apr 22, 2025 at 01:20:52PM +0100, Kieran Bingham wrote:
> From: Umang Jain <umang.jain@ideasonboard.com>
>
> CCI_REG_HNUM should be using CCI_REG16_LE() instead of CCI_REG8()
> as HNUM spans from 0x302e[0:7] to 0x302f[0:3].
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Does this need Fixes:/Cc: stable tags?
> ---
> drivers/media/i2c/imx335.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index db424b178e98..0418875e996c 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -31,7 +31,7 @@
> #define IMX335_REG_CPWAIT_TIME CCI_REG8(0x300d)
> #define IMX335_REG_WINMODE CCI_REG8(0x3018)
> #define IMX335_REG_HTRIMMING_START CCI_REG16_LE(0x302c)
> -#define IMX335_REG_HNUM CCI_REG8(0x302e)
> +#define IMX335_REG_HNUM CCI_REG16_LE(0x302e)
>
> /* Lines per frame */
> #define IMX335_REG_VMAX CCI_REG24_LE(0x3030)
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2025-04-25 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 12:20 [PATCH] media: imx335: Use correct register width for HNUM Kieran Bingham
2025-04-25 7:58 ` Sakari Ailus [this message]
2025-04-25 8:29 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAtAtp2epJCs0RaN@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.