Re: [PATCH v2 1/3] perf vendor events arm64: Fill up Desc field for Hisi hip08 hha pmu

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Fri, Apr 25, 2025 at 12:06:54PM +0100, Jonathan Cameron wrote:
> On Fri, 18 Apr 2025 15:08:10 +0800
> Junhao He <hejunhao3@huawei.com> wrote:
> 
> > In the same PMU, when some JSON events have the "BriefDescription" field
> > populated while others do not, the cmp_sevent() function will split these
> > two types of events into separate groups. As a result, when using perf
> > list to display events, the two types of events cannot be grouped together
> > in the output.
> > 
> > before patch:
> >  $ perf list pmu
> >  ...
> >  uncore hha:
> >    hisi_sccl1_hha2/sdir-hit/
> >    hisi_sccl1_hha2/sdir-lookup/
> >  ...
> >  uncore hha:
> >    edir-hit
> >       [Count of The number of HHA E-Dir hit operations. Unit: hisi_sccl1_hha2]
> >  ...
> > 
> > after patch:
> >  $ perf list pmu
> >  ...
> >  uncore hha:
> >    edir-hit
> >       [Count of The number of HHA E-Dir hit operations. Unit: hisi_sccl1_hha2]
> >    sdir-hit
> >       [Count of The number of HHA S-Dir hit operations. Unit: hisi_sccl1_hha2]
> >    sdir-lookup
> >       [Count of the number of HHA S-Dir lookup operations. Unit: hisi_sccl1_hha2]
> >  ...
> > 
> > Signed-off-by: Junhao He <hejunhao3@huawei.com>
> > Reviewed-by: James Clark <james.clark@linaro.org>
> One trivial comment inline that might be good to tidy up.

These can come as a follow up patch, I think.

> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Applied.

- Arnaldo