All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH v4 0/2] block: discard alignment fixes
Date: Fri, 25 Apr 2025 16:42:53 +0200	[thread overview]
Message-ID: <aAufbVJQvQMoH89X@redhat.com> (raw)
In-Reply-To: <20250417150528.76470-1-stefanha@redhat.com>

Am 17.04.2025 um 17:05 hat Stefan Hajnoczi geschrieben:
> v4:
> - Mention -EINVAL in bdrv_co_pdiscard() comment [Kevin]
> v3:
> - Refine error handling when pdiscard_alignment is not a multiple of request_alignment [Hanna]
> v2:
> - Fix inverted logic in alignment check [Qing Wang]
> 
> Two discard alignment issues were identified in
> https://issues.redhat.com/browse/RHEL-86032:
> 1. pdiscard_alignment is not populated for host_device in file-posix.c.
> 2. Misaligned head/tail discard requests are not skipped when file-posix.c
>    returns -EINVAL. This causes an undesired pause when guests are configured
>    with werror=stop.

Thanks, applied to the block branch.

Kevin



      parent reply	other threads:[~2025-04-25 14:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 15:05 [PATCH v4 0/2] block: discard alignment fixes Stefan Hajnoczi
2025-04-17 15:05 ` [PATCH v4 1/2] file-posix: probe discard alignment on Linux block devices Stefan Hajnoczi
2025-04-17 15:05 ` [PATCH v4 2/2] block/io: skip head/tail requests on EINVAL Stefan Hajnoczi
2025-04-25 14:42 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAufbVJQvQMoH89X@redhat.com \
    --to=kwolf@redhat.com \
    --cc=fam@euphon.net \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.