All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Sunny Zhu <sunnyzhyy@qq.com>
Cc: qemu-devel@nongnu.org, eblake@redhat.com, hreitz@redhat.com,
	qemu-block@nongnu.org
Subject: Re: [PATCH v2] block: Remove unused callback function *bdrv_aio_pdiscard
Date: Fri, 25 Apr 2025 17:12:54 +0200	[thread overview]
Message-ID: <aAumdnNyLCG-EfFF@redhat.com> (raw)
In-Reply-To: <tencent_7140D2E54157D98CF3D9E64B1A007A1A7906@qq.com>

Am 21.04.2025 um 20:21 hat Sunny Zhu geschrieben:
> The bytes type in *bdrv_aio_pdiscard should be int64_t rather than int.
> 
> There are no drivers implementing the *bdrv_aio_pdiscard() callback,
> it appears to be an unused function. Therefore, we'll simply remove it
> instead of fixing it.
> 
> Additionally, coroutine-based callbacks are preferred. If someone needs
> to implement bdrv_aio_pdiscard, a coroutine-based version would be
> straightforward to implement.
> 
> Signed-off-by: Sunny Zhu <sunnyzhyy@qq.com>

Thanks, applied to the block branch.

Kevin



      parent reply	other threads:[~2025-04-25 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21 18:21 [PATCH v2] block: Remove unused callback function *bdrv_aio_pdiscard Sunny Zhu
2025-04-22  7:09 ` Philippe Mathieu-Daudé
2025-04-25 15:12 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAumdnNyLCG-EfFF@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sunnyzhyy@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.