From: Andy Shevchenko <andy@kernel.org>
To: Jonathan Santos <Jonathan.Santos@analog.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
nuno.sa@analog.com, Michael.Hennerich@analog.com,
marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
marcelo.schmitt1@gmail.com, linus.walleij@linaro.org,
brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org,
jonath4nns@gmail.com, dlechner@baylibre.com
Subject: Re: [PATCH v7 10/12] iio: adc: ad7768-1: replace manual attribute declaration
Date: Thu, 8 May 2025 22:31:07 +0300 [thread overview]
Message-ID: <aB0GeyWALeE3mDOx@smile.fi.intel.com> (raw)
In-Reply-To: <7987725e62f53c4b2cf74dacced0a47ad055f4a9.1746662899.git.Jonathan.Santos@analog.com>
On Thu, May 08, 2025 at 02:05:13PM -0300, Jonathan Santos wrote:
> Use read_avail callback from struct iio_info to replace the manual
> declaration of sampling_frequency_available attribute.
...
> +static void ad7768_fill_samp_freq_tbl(struct ad7768_state *st)
> +{
> + unsigned int i;
> +
> + for (i = 0; i < ARRAY_SIZE(ad7768_clk_config); i++)
> + st->samp_freq_avail[i] = DIV_ROUND_CLOSEST(st->mclk_freq,
> + ad7768_clk_config[i].clk_div);
st->samp_freq_avail[i] =
DIV_ROUND_CLOSEST(st->mclk_freq, ad7768_clk_config[i].clk_div);
is slightly better formatting for this.
> +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-05-08 19:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 17:02 [PATCH v7 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Santos
2025-05-08 17:03 ` [PATCH v7 01/12] iio: adc: ad7768-1: reorganize driver headers Jonathan Santos
2025-05-08 19:22 ` Andy Shevchenko
2025-05-11 15:05 ` Jonathan Cameron
2025-05-08 17:03 ` [PATCH v7 02/12] dt-bindings: trigger-source: add generic GPIO trigger source Jonathan Santos
2025-05-08 17:56 ` David Lechner
2025-05-09 16:11 ` Conor Dooley
2025-05-13 13:24 ` Linus Walleij
2025-05-08 17:03 ` [PATCH v7 03/12] dt-bindings: iio: adc: ad7768-1: add trigger-sources property Jonathan Santos
2025-05-09 16:12 ` Conor Dooley
2025-05-09 16:18 ` Conor Dooley
2025-05-12 12:59 ` Rob Herring
2025-05-08 17:03 ` [PATCH v7 04/12] dt-bindings: iio: adc: ad7768-1: Document GPIO controller Jonathan Santos
2025-05-08 17:03 ` [PATCH v7 05/12] dt-bindings: iio: adc: ad7768-1: document regulator provider property Jonathan Santos
2025-05-08 17:04 ` [PATCH v7 06/12] iio: adc: ad7768-1: add regulator to control VCM output Jonathan Santos
2025-05-08 17:04 ` [PATCH v7 07/12] iio: adc: ad7768-1: Add GPIO controller support Jonathan Santos
2025-05-08 17:04 ` [PATCH v7 08/12] iio: adc: ad7768-1: add multiple scan types to support 16-bits mode Jonathan Santos
2025-05-08 18:01 ` David Lechner
2025-05-08 18:03 ` David Lechner
2025-05-08 17:04 ` [PATCH v7 09/12] iio: adc: ad7768-1: add support for Synchronization over SPI Jonathan Santos
2025-05-08 18:45 ` David Lechner
2025-05-08 17:05 ` [PATCH v7 10/12] iio: adc: ad7768-1: replace manual attribute declaration Jonathan Santos
2025-05-08 19:31 ` Andy Shevchenko [this message]
2025-05-08 17:05 ` [PATCH v7 11/12] iio: adc: ad7768-1: add filter type and oversampling ratio attributes Jonathan Santos
2025-05-08 19:39 ` Andy Shevchenko
2025-05-08 17:05 ` [PATCH v7 12/12] iio: adc: ad7768-1: add low pass -3dB cutoff attribute Jonathan Santos
2025-05-11 15:11 ` [PATCH v7 00/12] iio: adc: ad7768-1: Add features, improvements, and fixes Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aB0GeyWALeE3mDOx@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jonath4nns@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.